diff mbox series

[v4,1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

Message ID 1548073351-13739-2-git-send-email-min.guo@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Add MediaTek MUSB Controller Driver | expand

Commit Message

Min Guo Jan. 21, 2019, 12:22 p.m. UTC 
From: Min Guo <min.guo@mediatek.com>

This adds support for MediaTek musb controller in
host, peripheral and otg mode.

Signed-off-by: Min Guo <min.guo@mediatek.com>
---
changes in v4:
suggested by Sergei:
1. String alignment

changes in v3:
1. no changes

changes in v2:
suggested by Bin:
1. Modify DRC to DRD
suggested by Rob:
2. Drop the "<soc-model>-musb" in compatible
3. Remove phy-names
4. Add space after comma in clock-names
---
 .../devicetree/bindings/usb/mediatek,musb.txt      | 43 ++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt

Comments

Rob Herring (Arm) Jan. 21, 2019, 3:14 p.m. UTC | #1 
On Mon, Jan 21, 2019 at 08:22:26PM +0800, min.guo@mediatek.com wrote:
> From: Min Guo <min.guo@mediatek.com>
> 
> This adds support for MediaTek musb controller in
> host, peripheral and otg mode.
> 
> Signed-off-by: Min Guo <min.guo@mediatek.com>
> ---
> changes in v4:
> suggested by Sergei:
> 1. String alignment
> 
> changes in v3:
> 1. no changes
> 
> changes in v2:
> suggested by Bin:
> 1. Modify DRC to DRD
> suggested by Rob:
> 2. Drop the "<soc-model>-musb" in compatible

This is not what I said. I gave you the exact text to put.

> 3. Remove phy-names
> 4. Add space after comma in clock-names
> ---
>  .../devicetree/bindings/usb/mediatek,musb.txt      | 43 ++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> new file mode 100644
> index 0000000..4305770
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> @@ -0,0 +1,43 @@
> +MediaTek musb DRD/OTG controller
> +-------------------------------------------
> +
> +Required properties:
> + - compatible      : should be "mediatek,mtk-musb"
> + - reg             : specifies physical base address and size of
> +                     the registers
> + - interrupts      : interrupt used by musb controller
> + - interrupt-names : must be "mc"
> + - phys            : PHY specifier for the OTG phy
> + - dr_mode         : should be one of "host", "peripheral" or "otg",
> +                     refer to usb/generic.txt
> + - clocks          : a list of phandle + clock-specifier pairs, one for
> +                     each entry in clock-names
> + - clock-names     : must contain "main", "mcu", "univpll"
> +                     for clocks of controller
> +
> +Optional properties:
> + - extcon          : external connector for VBUS and ID pin changes detection,
> +                     needed when supports dual-role mode

Again, do not use extcon in new bindings.

> + - vbus-supply     : reference to the VBUS regulator, needed when supports
> +                     dual-role mode
> + - power-domains   : a phandle to USB power domain node to control USB's
> +                     MTCMOS
> +
> +Example:
> +
> +usb2: usb@11200000 {
> +	compatible = "mediatek,mt2701-musb",
> +		     "mediatek,mtk-musb";
> +	reg = <0 0x11200000 0 0x1000>;
> +	interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
> +	interrupt-names = "mc";
> +	phys = <&u2port2 PHY_TYPE_USB2>;
> +	vbus-supply = <&usb_vbus>;
> +	extcon = <&extcon_usb>;
> +	dr_mode = "otg";
> +	clocks = <&pericfg CLK_PERI_USB0>,
> +		 <&pericfg CLK_PERI_USB0_MCU>,
> +		 <&pericfg CLK_PERI_USB_SLV>;
> +	clock-names = "main","mcu","univpll";
> +	power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>;
> +};
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Min Guo Jan. 22, 2019, 9:36 a.m. UTC | #2 
Hi Bin,

Sorry to bother you again, I encounter a problem about the extcon
property.

I don't find a common driver describing the usb-connector. Is
there any driver that I can refer to, specially the way to switch MUSB
controller between host and device mode? 
If it needs to implement by myself, is it possible to emulate an
usb-connector driver by extcon-usb-gpio, and also use the notifier
mechanism or can you give me some advices?


Hi Rob,

On Mon, 2019-01-21 at 09:14 -0600, Rob Herring wrote:
> On Mon, Jan 21, 2019 at 08:22:26PM +0800, min.guo@mediatek.com wrote:
> > From: Min Guo <min.guo@mediatek.com>
> > 
> > This adds support for MediaTek musb controller in
> > host, peripheral and otg mode.
> > 
> > Signed-off-by: Min Guo <min.guo@mediatek.com>
> > ---
> > changes in v4:
> > suggested by Sergei:
> > 1. String alignment
> > 
> > changes in v3:
> > 1. no changes
> > 
> > changes in v2:
> > suggested by Bin:
> > 1. Modify DRC to DRD
> > suggested by Rob:
> > 2. Drop the "<soc-model>-musb" in compatible
> 
> This is not what I said. I gave you the exact text to put.

Sorry to misunderstood your meaning last time,  I will modify it in next
patch.
	compatible: should be one of "mediatek,mt2701-musb"...,followed by
"mediatek,mtk-musb"

> > 3. Remove phy-names
> > 4. Add space after comma in clock-names
> > ---
> >  .../devicetree/bindings/usb/mediatek,musb.txt      | 43 ++++++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > new file mode 100644
> > index 0000000..4305770
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > @@ -0,0 +1,43 @@
> > +MediaTek musb DRD/OTG controller
> > +-------------------------------------------
> > +
> > +Required properties:
> > + - compatible      : should be "mediatek,mtk-musb"
> > + - reg             : specifies physical base address and size of
> > +                     the registers
> > + - interrupts      : interrupt used by musb controller
> > + - interrupt-names : must be "mc"
> > + - phys            : PHY specifier for the OTG phy
> > + - dr_mode         : should be one of "host", "peripheral" or "otg",
> > +                     refer to usb/generic.txt
> > + - clocks          : a list of phandle + clock-specifier pairs, one for
> > +                     each entry in clock-names
> > + - clock-names     : must contain "main", "mcu", "univpll"
> > +                     for clocks of controller
> > +
> > +Optional properties:
> > + - extcon          : external connector for VBUS and ID pin changes detection,
> > +                     needed when supports dual-role mode
> 
> Again, do not use extcon in new bindings.

Thanks, ok.

> > + - vbus-supply     : reference to the VBUS regulator, needed when supports
> > +                     dual-role mode
> > + - power-domains   : a phandle to USB power domain node to control USB's
> > +                     MTCMOS
> > +
> > +Example:
> > +
> > +usb2: usb@11200000 {
> > +	compatible = "mediatek,mt2701-musb",
> > +		     "mediatek,mtk-musb";
> > +	reg = <0 0x11200000 0 0x1000>;
> > +	interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
> > +	interrupt-names = "mc";
> > +	phys = <&u2port2 PHY_TYPE_USB2>;
> > +	vbus-supply = <&usb_vbus>;
> > +	extcon = <&extcon_usb>;
> > +	dr_mode = "otg";
> > +	clocks = <&pericfg CLK_PERI_USB0>,
> > +		 <&pericfg CLK_PERI_USB0_MCU>,
> > +		 <&pericfg CLK_PERI_USB_SLV>;
> > +	clock-names = "main","mcu","univpll";
> > +	power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>;
> > +};
> > -- 
> > 1.9.1
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Regards,
Min.
Bin Liu Jan. 22, 2019, 2:33 p.m. UTC | #3 
Hi Min,

On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote:
> Hi Bin,
> 
> Sorry to bother you again, I encounter a problem about the extcon
> property.
> 
> I don't find a common driver describing the usb-connector. Is
> there any driver that I can refer to, specially the way to switch MUSB
> controller between host and device mode? 
> If it needs to implement by myself, is it possible to emulate an
> usb-connector driver by extcon-usb-gpio, and also use the notifier
> mechanism or can you give me some advices?

I am afraid I am unable to help you on this. I wasn't really pay
attention when usb-connector was introduced and not sure how it can
replace extcon. Now after read usb-connector.txt, it seems the binding
only defines a/b/c-connector, but not ab-connector, and there is no
enough information (at least for me) explaining how VBUS and ID fix into
this usb-connector binding.

Maybe Rob can provide some hint.

Regards,
-Bin.
Min Guo Jan. 25, 2019, 2:07 a.m. UTC | #4 
Hi Bin,

Thanks for your help.

Hi Rob,

I find that Samsung describes the usb-connector attribute in DTS, and
uses a private driver.
And try to write DTS as following:

usb-connector node:
musb_con: musb_connector{
    compatible = "linux,extcon-usb-gpio","usb-b-connector";
    lable = "micro-USB";
    type = "micro";
    id-gpio = <&pio 44 GPIO_ACTIVE_HIGH>
    vbus-supply = <&usb_vbus>;
    port {
        usb_to_connector: endpoint {
            remote-endpoint = <&connector_to_usb>;
        };
    };
};

usb node:
&usb2{
    status = "okay";
    port {
        connector_to_usb: endpoint {
            remote-endpoint = <&usb_to_connector>;
        };
    };
}

Can I describe usb-connector like this? Or can you give me some advices?

Regards,
Min.

On Tue, 2019-01-22 at 08:33 -0600, Bin Liu wrote:
> Hi Min,
> 
> On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote:
> > Hi Bin,
> > 
> > Sorry to bother you again, I encounter a problem about the extcon
> > property.
> > 
> > I don't find a common driver describing the usb-connector. Is
> > there any driver that I can refer to, specially the way to switch MUSB
> > controller between host and device mode? 
> > If it needs to implement by myself, is it possible to emulate an
> > usb-connector driver by extcon-usb-gpio, and also use the notifier
> > mechanism or can you give me some advices?
> 
> I am afraid I am unable to help you on this. I wasn't really pay
> attention when usb-connector was introduced and not sure how it can
> replace extcon. Now after read usb-connector.txt, it seems the binding
> only defines a/b/c-connector, but not ab-connector, and there is no
> enough information (at least for me) explaining how VBUS and ID fix into
> this usb-connector binding.
> 
> Maybe Rob can provide some hint.
> 
> Regards,
> -Bin.
Min Guo Feb. 14, 2019, 8:30 a.m. UTC | #5 
Hi Rob,

Sorry to bother you again.
Can I describe usb-connector in usb node like this?

usb2: usb@11200000 {
   compatible = "mediatek,mt2701-musb";
                "mediatek,mtk-musb";
   reg = <0 0x11200000 0 0x1000>;
   ...
   usb_connector: musb_connector {
       compatible = "usb-b-connector";
       label = "micro-USB";
       type = "micro";
       extcon = <&extcon_usb>;
       vbus-supply = <&usb_vbus>;
   };
};

Regards,
Min.


On Fri, 2019-01-25 at 10:07 +0800, Min Guo wrote:
> Hi Bin,
> 
> Thanks for your help.
> 
> Hi Rob,
> 
> I find that Samsung describes the usb-connector attribute in DTS, and
> uses a private driver.
> And try to write DTS as following:
> 
> usb-connector node:
> musb_con: musb_connector{
>     compatible = "linux,extcon-usb-gpio","usb-b-connector";
>     lable = "micro-USB";
>     type = "micro";
>     id-gpio = <&pio 44 GPIO_ACTIVE_HIGH>
>     vbus-supply = <&usb_vbus>;
>     port {
>         usb_to_connector: endpoint {
>             remote-endpoint = <&connector_to_usb>;
>         };
>     };
> };
> 
> usb node:
> &usb2{
>     status = "okay";
>     port {
>         connector_to_usb: endpoint {
>             remote-endpoint = <&usb_to_connector>;
>         };
>     };
> }
> 
> Can I describe usb-connector like this? Or can you give me some advices?
> 
> Regards,
> Min.
> 
> On Tue, 2019-01-22 at 08:33 -0600, Bin Liu wrote:
> > Hi Min,
> > 
> > On Tue, Jan 22, 2019 at 05:36:13PM +0800, Min Guo wrote:
> > > Hi Bin,
> > > 
> > > Sorry to bother you again, I encounter a problem about the extcon
> > > property.
> > > 
> > > I don't find a common driver describing the usb-connector. Is
> > > there any driver that I can refer to, specially the way to switch MUSB
> > > controller between host and device mode? 
> > > If it needs to implement by myself, is it possible to emulate an
> > > usb-connector driver by extcon-usb-gpio, and also use the notifier
> > > mechanism or can you give me some advices?
> > 
> > I am afraid I am unable to help you on this. I wasn't really pay
> > attention when usb-connector was introduced and not sure how it can
> > replace extcon. Now after read usb-connector.txt, it seems the binding
> > only defines a/b/c-connector, but not ab-connector, and there is no
> > enough information (at least for me) explaining how VBUS and ID fix into
> > this usb-connector binding.
> > 
> > Maybe Rob can provide some hint.
> > 
> > Regards,
> > -Bin.
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
new file mode 100644
index 0000000..4305770
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
@@ -0,0 +1,43 @@ 
+MediaTek musb DRD/OTG controller
+-------------------------------------------
+
+Required properties:
+ - compatible      : should be "mediatek,mtk-musb"
+ - reg             : specifies physical base address and size of
+                     the registers
+ - interrupts      : interrupt used by musb controller
+ - interrupt-names : must be "mc"
+ - phys            : PHY specifier for the OTG phy
+ - dr_mode         : should be one of "host", "peripheral" or "otg",
+                     refer to usb/generic.txt
+ - clocks          : a list of phandle + clock-specifier pairs, one for
+                     each entry in clock-names
+ - clock-names     : must contain "main", "mcu", "univpll"
+                     for clocks of controller
+
+Optional properties:
+ - extcon          : external connector for VBUS and ID pin changes detection,
+                     needed when supports dual-role mode
+ - vbus-supply     : reference to the VBUS regulator, needed when supports
+                     dual-role mode
+ - power-domains   : a phandle to USB power domain node to control USB's
+                     MTCMOS
+
+Example:
+
+usb2: usb@11200000 {
+	compatible = "mediatek,mt2701-musb",
+		     "mediatek,mtk-musb";
+	reg = <0 0x11200000 0 0x1000>;
+	interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_LOW>;
+	interrupt-names = "mc";
+	phys = <&u2port2 PHY_TYPE_USB2>;
+	vbus-supply = <&usb_vbus>;
+	extcon = <&extcon_usb>;
+	dr_mode = "otg";
+	clocks = <&pericfg CLK_PERI_USB0>,
+		 <&pericfg CLK_PERI_USB0_MCU>,
+		 <&pericfg CLK_PERI_USB_SLV>;
+	clock-names = "main","mcu","univpll";
+	power-domains = <&scpsys MT2701_POWER_DOMAIN_IFR_MSC>;
+};