diff mbox series

mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay

Message ID 1548245125-31664-1-git-send-email-chaotian.jing@mediatek.com (mailing list archive)
State New, archived
Headers show
Series mmc: mediatek: fix incorrect register setting of hs400_cmd_int_delay | expand

Commit Message

Chaotian Jing (井朝天) Jan. 23, 2019, 12:05 p.m. UTC
to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
register.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ulf Hansson Jan. 28, 2019, 12:03 p.m. UTC | #1
On Wed, 23 Jan 2019 at 13:05, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
>
> to set cmd internal delay, need set PAD_TUNE register but not PAD_CMD_TUNE
> register.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>

Applied for fixes, adding a fixes+stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mtk-sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 8afeaf8..833ef05 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -846,7 +846,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
>
>         if (timing == MMC_TIMING_MMC_HS400 &&
>             host->dev_comp->hs400_tune)
> -               sdr_set_field(host->base + PAD_CMD_TUNE,
> +               sdr_set_field(host->base + tune_reg,
>                               MSDC_PAD_TUNE_CMDRRDLY,
>                               host->hs400_cmd_int_delay);
>         dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,
> --
> 1.8.1.1.dirty
>
diff mbox series

Patch

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 8afeaf8..833ef05 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -846,7 +846,7 @@  static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
 
 	if (timing == MMC_TIMING_MMC_HS400 &&
 	    host->dev_comp->hs400_tune)
-		sdr_set_field(host->base + PAD_CMD_TUNE,
+		sdr_set_field(host->base + tune_reg,
 			      MSDC_PAD_TUNE_CMDRRDLY,
 			      host->hs400_cmd_int_delay);
 	dev_dbg(host->dev, "sclk: %d, timing: %d\n", host->mmc->actual_clock,