| Message ID | 1567149298-29366-4-git-send-email-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,01/11] dt-bindings: phy-mtk-tphy: add two optional properties for u2phy | expand |
On Fri, 30 Aug 2019 15:14:51 +0800, Chunfeng Yun wrote: > Usually the digital and analog phys use the same reference clock, > but on some platforms, they are separated, so add another optional > clock to support it. > In order to keep the clock names consistent with PHY IP's, use > the da_ref for analog phy and ref clock for digital phy. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > v2: fix typo of analog and needed > --- > Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi Rob, On 18/09/19 1:58 AM, Rob Herring wrote: > On Fri, 30 Aug 2019 15:14:51 +0800, Chunfeng Yun wrote: >> Usually the digital and analog phys use the same reference clock, >> but on some platforms, they are separated, so add another optional >> clock to support it. >> In order to keep the clock names consistent with PHY IP's, use >> the da_ref for analog phy and ref clock for digital phy. >> >> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >> --- >> v2: fix typo of analog and needed >> --- >> Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> > > Acked-by: Rob Herring <robh@kernel.org> I see you've acked a couple of patches in the series. However the other dt-binding patch neither has an Ack or NAK. Is there a specific reason or can I merge the series? Thanks Kishon
Hi Rob, On Wed, 2019-10-23 at 11:10 +0530, Kishon Vijay Abraham I wrote: > Hi Rob, > > On 18/09/19 1:58 AM, Rob Herring wrote: > > On Fri, 30 Aug 2019 15:14:51 +0800, Chunfeng Yun wrote: > >> Usually the digital and analog phys use the same reference clock, > >> but on some platforms, they are separated, so add another optional > >> clock to support it. > >> In order to keep the clock names consistent with PHY IP's, use > >> the da_ref for analog phy and ref clock for digital phy. > >> > >> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > >> --- > >> v2: fix typo of analog and needed > >> --- > >> Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 7 +++++-- > >> 1 file changed, 5 insertions(+), 2 deletions(-) > >> > > > > Acked-by: Rob Herring <robh@kernel.org> > > I see you've acked a couple of patches in the series. However the other > dt-binding patch neither has an Ack or NAK. Is there a specific reason or can I > merge the series? Ping? > > Thanks > Kishon
diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt index 48bc1a2e9299..a859b0db4051 100644 --- a/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt +++ b/Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt @@ -41,9 +41,12 @@ Optional properties (PHY_TYPE_USB2 port (child) node): - clocks : a list of phandle + clock-specifier pairs, one for each entry in clock-names - clock-names : may contain - "ref": 48M reference clock for HighSpeed anolog phy; and 26M - reference clock for SuperSpeed anolog phy, sometimes is + "ref": 48M reference clock for HighSpeed (digital) phy; and 26M + reference clock for SuperSpeed (digital) phy, sometimes is 24M, 25M or 27M, depended on platform. + "da_ref": the reference clock of analog phy, used if the clocks + of analog and digital phys are separated, otherwise uses + "ref" clock only if needed. - mediatek,eye-src : u32, the value of slew rate calibrate - mediatek,eye-vrt : u32, the selection of VRT reference voltage
Usually the digital and analog phys use the same reference clock, but on some platforms, they are separated, so add another optional clock to support it. In order to keep the clock names consistent with PHY IP's, use the da_ref for analog phy and ref clock for digital phy. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- v2: fix typo of analog and needed --- Documentation/devicetree/bindings/phy/phy-mtk-tphy.txt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)