diff mbox series

[v1,1/1] pinctrl: mediatek: remove shadow variable declaration

Message ID 1586255632-27528-1-git-send-email-light.hsieh@mediatek.com (mailing list archive)
State New, archived
Headers show
Series [v1,1/1] pinctrl: mediatek: remove shadow variable declaration | expand

Commit Message

Light Hsieh April 7, 2020, 10:33 a.m. UTC 
From: Light Hsieh <light.hsieh@mediatek.com>

Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()

Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
---
 drivers/pinctrl/mediatek/pinctrl-paris.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Stanley Chu April 7, 2020, 1:37 p.m. UTC | #1 
Hi Light,

On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
> 
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
> 
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
> ---
>  drivers/pinctrl/mediatek/pinctrl-paris.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index 83bf29c..8f75115 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
>  	case MTK_PIN_CONFIG_PU_ADV:
>  	case MTK_PIN_CONFIG_PD_ADV:
>  		if (hw->soc->adv_pull_get) {
> -			bool pullup;
> -
>  			pullup = param == MTK_PIN_CONFIG_PU_ADV;
>  			err = hw->soc->adv_pull_get(hw, desc, pullup, &ret);
>  		} else

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Yingjoe Chen April 7, 2020, 1:41 p.m. UTC | #2 
On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote:
> From: Light Hsieh <light.hsieh@mediatek.com>
> 
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
> 
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>
> ---
>  drivers/pinctrl/mediatek/pinctrl-paris.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index 83bf29c..8f75115 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
>  	case MTK_PIN_CONFIG_PU_ADV:
>  	case MTK_PIN_CONFIG_PD_ADV:
>  		if (hw->soc->adv_pull_get) {
> -			bool pullup;
> -
>  			pullup = param == MTK_PIN_CONFIG_PU_ADV;
>  			err = hw->soc->adv_pull_get(hw, desc, pullup, &ret);
>  		} else

Hi, Light,

What is this based on?
The code in v5.6 doesn't looks like this.

Joe.C
Linus Walleij April 16, 2020, 8:02 a.m. UTC | #3 
On Tue, Apr 7, 2020 at 12:34 PM <light.hsieh@mediatek.com> wrote:

> From: Light Hsieh <light.hsieh@mediatek.com>
>
> Remove shadow declaration of variable 'pullup' in mtk_pinconf_get()
>
> Signed-off-by: Light Hsieh <light.hsieh@mediatek.com>

Patch applied for fixes, thanks for fixing this!

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
index 83bf29c..8f75115 100644
--- a/drivers/pinctrl/mediatek/pinctrl-paris.c
+++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
@@ -164,8 +164,6 @@  static int mtk_pinconf_get(struct pinctrl_dev *pctldev,
 	case MTK_PIN_CONFIG_PU_ADV:
 	case MTK_PIN_CONFIG_PD_ADV:
 		if (hw->soc->adv_pull_get) {
-			bool pullup;
-
 			pullup = param == MTK_PIN_CONFIG_PU_ADV;
 			err = hw->soc->adv_pull_get(hw, desc, pullup, &ret);
 		} else