| Message ID | 1595404275-8449-1-git-send-email-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] usb: mtu3: convert to devm_platform_ioremap_resource_byname | expand |
Hi, Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > Use devm_platform_ioremap_resource_byname() to simplify code > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> why is it so that your patches always come base64 encoded? They look fine on the email client, but when I try to pipe the message to git am it always gives me a lot of trouble and I have to manually decode the body of your messages and recombine with the patch. Can you try to send your patches as actual plain text without encoding the body with base64?
Hi Felip, On Mon, 2020-09-07 at 10:42 +0300, Felipe Balbi wrote: > Hi, > > Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > > Use devm_platform_ioremap_resource_byname() to simplify code > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > why is it so that your patches always come base64 encoded? They look > fine on the email client, but when I try to pipe the message to git am > it always gives me a lot of trouble and I have to manually decode the > body of your messages and recombine with the patch. > > Can you try to send your patches as actual plain text without encoding > the body with base64? Missed the email. Sorry for inconvenience! Is only the commit message base64 encoded, or includes the codes? >
Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > Hi Felip, > > > On Mon, 2020-09-07 at 10:42 +0300, Felipe Balbi wrote: >> Hi, >> >> Chunfeng Yun <chunfeng.yun@mediatek.com> writes: >> > Use devm_platform_ioremap_resource_byname() to simplify code >> > >> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >> >> why is it so that your patches always come base64 encoded? They look >> fine on the email client, but when I try to pipe the message to git am >> it always gives me a lot of trouble and I have to manually decode the >> body of your messages and recombine with the patch. >> >> Can you try to send your patches as actual plain text without encoding >> the body with base64? > Missed the email. > > Sorry for inconvenience! > Is only the commit message base64 encoded, or includes the codes? The entire thing :-)
On Thu, 2020-09-24 at 10:20 +0300, Felipe Balbi wrote: > Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > > > Hi Felip, > > > > > > On Mon, 2020-09-07 at 10:42 +0300, Felipe Balbi wrote: > >> Hi, > >> > >> Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > >> > Use devm_platform_ioremap_resource_byname() to simplify code > >> > > >> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > >> > >> why is it so that your patches always come base64 encoded? They look > >> fine on the email client, but when I try to pipe the message to git am > >> it always gives me a lot of trouble and I have to manually decode the > >> body of your messages and recombine with the patch. > >> > >> Can you try to send your patches as actual plain text without encoding > >> the body with base64? > > Missed the email. > > > > Sorry for inconvenience! > > Is only the commit message base64 encoded, or includes the codes? > > The entire thing :-) I checked my gitconfig, use the default encoding, that is 8bit. if you still encounter the issue when apply the series patch https://patchwork.kernel.org/patch/11764953/ I'll resend them by "git send-email --transfer-encoding=8bit 00*" >
diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c index 9dd0216..ca48089 100644 --- a/drivers/usb/mtu3/mtu3_core.c +++ b/drivers/usb/mtu3/mtu3_core.c @@ -828,7 +828,6 @@ int ssusb_gadget_init(struct ssusb_mtk *ssusb) struct device *dev = ssusb->dev; struct platform_device *pdev = to_platform_device(dev); struct mtu3 *mtu = NULL; - struct resource *res; int ret = -ENOMEM; mtu = devm_kzalloc(dev, sizeof(struct mtu3), GFP_KERNEL); @@ -840,8 +839,7 @@ int ssusb_gadget_init(struct ssusb_mtk *ssusb) return mtu->irq; dev_info(dev, "irq %d\n", mtu->irq); - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mac"); - mtu->mac_base = devm_ioremap_resource(dev, res); + mtu->mac_base = devm_platform_ioremap_resource_byname(pdev, "mac"); if (IS_ERR(mtu->mac_base)) { dev_err(dev, "error mapping memory for dev mac\n"); return PTR_ERR(mtu->mac_base); diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index 9c256ea..d44d541 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c @@ -216,7 +216,6 @@ static int get_ssusb_rscs(struct platform_device *pdev, struct ssusb_mtk *ssusb) struct device_node *node = pdev->dev.of_node; struct otg_switch_mtk *otg_sx = &ssusb->otg_switch; struct device *dev = &pdev->dev; - struct resource *res; int i; int ret; @@ -263,8 +262,7 @@ static int get_ssusb_rscs(struct platform_device *pdev, struct ssusb_mtk *ssusb) } } - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ippc"); - ssusb->ippc_base = devm_ioremap_resource(dev, res); + ssusb->ippc_base = devm_platform_ioremap_resource_byname(pdev, "ippc"); if (IS_ERR(ssusb->ippc_base)) return PTR_ERR(ssusb->ippc_base);
Use devm_platform_ioremap_resource_byname() to simplify code Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/usb/mtu3/mtu3_core.c | 4 +--- drivers/usb/mtu3/mtu3_plat.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-)