diff mbox series

[V5,14/17] dt-bindings: regulator: add DVFSRC regulator dt-bindings

Message ID 1600052684-21198-15-git-send-email-henryc.chen@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Add driver for dvfsrc, support for active state of scpsys | expand

Commit Message

Henry Chen Sept. 14, 2020, 3:04 a.m. UTC 
From: "henryc.chen" <henryc.chen@mediatek.com>

Add a regulator as sub device into dvfsrc dt-bindings for MT8183.

Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Mark Brown Sept. 14, 2020, 12:32 p.m. UTC | #1 
On Mon, Sep 14, 2020 at 11:04:41AM +0800, Henry Chen wrote:

>  		clocks = <&infracfg CLK_INFRA_DVFSRC>;
>  		clock-names = "dvfsrc";
>  		#interconnect-cells = <1>;
> +		dvfsrc-regulator {
> +			compatible = "mediatek,mt8183-dvfsrc-regulator";

This device has only one possible parent, why does it need a compatible
string?
Henry Chen Sept. 15, 2020, 3:39 a.m. UTC | #2 
On Mon, 2020-09-14 at 13:32 +0100, Mark Brown wrote:
> On Mon, Sep 14, 2020 at 11:04:41AM +0800, Henry Chen wrote:
> 
> >  		clocks = <&infracfg CLK_INFRA_DVFSRC>;
> >  		clock-names = "dvfsrc";
> >  		#interconnect-cells = <1>;
> > +		dvfsrc-regulator {
> > +			compatible = "mediatek,mt8183-dvfsrc-regulator";
> 
> This device has only one possible parent, why does it need a compatible
> string?

Sorry, that was a mistake, it will be removed on next version.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
index 76ca61d..f88a72d 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
+++ b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
@@ -15,6 +15,11 @@  Required Properties:
 	"dvfsrc": DVFSRC module clock
 - clocks: Must contain an entry for each entry in clock-names.
 - #interconnect-cells : should contain 1
+- regulator : The DVFSRC regulator is modelled as a subdevice of the DVFSRC.
+	Because DVFSRC can request power directly via register read/write, likes
+	vcore which is a core power of mt8183. As such, the DVFSRC regulator
+	requires that DVFSRC nodes be present. shall contain only one of the
+	following: "mediatek,mt8183-dvfsrc-regulator"
 
 Example:
 
@@ -24,4 +29,13 @@  Example:
 		clocks = <&infracfg CLK_INFRA_DVFSRC>;
 		clock-names = "dvfsrc";
 		#interconnect-cells = <1>;
+		dvfsrc-regulator {
+			compatible = "mediatek,mt8183-dvfsrc-regulator";
+			dvfsrc_vcore: dvfsrc-vcore {
+				regulator-name = "dvfsrc-vcore";
+				regulator-min-microvolt = <725000>;
+				regulator-max-microvolt = <800000>;
+				regulator-always-on;
+			};
+		};
 	};