| Message ID | 1600061930-778-1-git-send-email-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: gadget: bcm63xx_udc: fix up the error of undeclared usb_debug_root | expand |
On Mon, Sep 14, 2020 at 01:38:50PM +0800, Chunfeng Yun wrote: > Fix up the build error caused by undeclared usb_debug_root > > Cc: stable <stable@vger.kernel.org> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root") Nit, you need a ' ' before the '(' character... thanks, greg k-h
On Mon, 2020-09-14 at 08:12 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 14, 2020 at 01:38:50PM +0800, Chunfeng Yun wrote: > > Fix up the build error caused by undeclared usb_debug_root > > > > Cc: stable <stable@vger.kernel.org> > > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root") > > Nit, you need a ' ' before the '(' character... Ok, thanks > > thanks, > > greg k-h
Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > Fix up the build error caused by undeclared usb_debug_root > > Cc: stable <stable@vger.kernel.org> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> $ patch -p1 --dry-run p.patch /usr/bin/patch: **** Only garbage was found in the patch input.
On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote: > Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > > > Fix up the build error caused by undeclared usb_debug_root > > > > Cc: stable <stable@vger.kernel.org> > > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root") > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > $ patch -p1 --dry-run p.patch > /usr/bin/patch: **** Only garbage was found in the patch input. > Please try to apply v2, https://patchwork.kernel.org/patch/11772911/ I indeed add a line code
Hi, Chunfeng Yun <chunfeng.yun@mediatek.com> writes: > On Thu, 2020-09-24 at 10:50 +0300, Felipe Balbi wrote: >> Chunfeng Yun <chunfeng.yun@mediatek.com> writes: >> >> > Fix up the build error caused by undeclared usb_debug_root >> > >> > Cc: stable <stable@vger.kernel.org> >> > Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root") >> > Reported-by: kernel test robot <lkp@intel.com> >> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> >> >> $ patch -p1 --dry-run p.patch >> /usr/bin/patch: **** Only garbage was found in the patch input. >> > Please try to apply v2, https://patchwork.kernel.org/patch/11772911/ > I indeed add a line code that worked, but the problem I have is that your patches always come base64 encoded. Make sure they come as plain text in the future :-)
diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c b/drivers/usb/gadget/udc/bcm63xx_udc.c index feaec00..9cd4a70 100644 --- a/drivers/usb/gadget/udc/bcm63xx_udc.c +++ b/drivers/usb/gadget/udc/bcm63xx_udc.c @@ -26,6 +26,7 @@ #include <linux/seq_file.h> #include <linux/slab.h> #include <linux/timer.h> +#include <linux/usb.h> #include <linux/usb/ch9.h> #include <linux/usb/gadget.h> #include <linux/workqueue.h>
Fix up the build error caused by undeclared usb_debug_root Cc: stable <stable@vger.kernel.org> Fixes: a66ada4f241c("usb: gadget: bcm63xx_udc: create debugfs directory under usb root") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/usb/gadget/udc/bcm63xx_udc.c | 1 + 1 file changed, 1 insertion(+)