diff mbox series

[v2] ASoC: mediatek: mt8192: skip first time data at the beginning of DMIC recording

Message ID 1605062722-8711-1-git-send-email-jiaxin.yu@mediatek.com (mailing list archive)
State New, archived
Headers show
Series [v2] ASoC: mediatek: mt8192: skip first time data at the beginning of DMIC recording | expand

Commit Message

Jiaxin Yu Nov. 11, 2020, 2:45 a.m. UTC
We can choose to drop away any length of data from the beginning according
to project needs. Some projects don't want to throw away any data, because
they want to use recorded data to do echo cancellation, so they have to
make sure that they are aligned with the reference data as much as
possible. Or there are other algorithms in the upper layer to eliminate
this noise. Or some projects want to eliminate this noise form the kernel
layer. However, the minimum recommended value is 50ms to skip pop noise.

Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
---
 This seems like something that would apply equally to all DMICs so should
 be done at a more general level, so we implement it in the DMIC driver.

 sound/soc/mediatek/Kconfig                              | 1 +
 sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Mark Brown Nov. 11, 2020, 3:47 p.m. UTC | #1
On Wed, 11 Nov 2020 10:45:22 +0800, Jiaxin Yu wrote:
> We can choose to drop away any length of data from the beginning according
> to project needs. Some projects don't want to throw away any data, because
> they want to use recorded data to do echo cancellation, so they have to
> make sure that they are aligned with the reference data as much as
> possible. Or there are other algorithms in the upper layer to eliminate
> this noise. Or some projects want to eliminate this noise form the kernel
> layer. However, the minimum recommended value is 50ms to skip pop noise.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: mediatek: mt8192: skip first time data at the beginning of DMIC recording
      commit: 2aff94e47da2e2006ceb53c00247218ea8a72770

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
index dc628fb6c1025..31f1431bf5792 100644
--- a/sound/soc/mediatek/Kconfig
+++ b/sound/soc/mediatek/Kconfig
@@ -175,6 +175,7 @@  config SND_SOC_MT8192_MT6359_RT1015_RT5682
 	select SND_SOC_MT6359
 	select SND_SOC_RT1015
 	select SND_SOC_RT5682_I2C
+	select SND_SOC_DMIC
 	help
 	  This adds ASoC driver for Mediatek MT8192 boards
 	  with the MT6359 RT1015 RT5682 audio codec.
diff --git a/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c b/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c
index 41d8a8567bb38..b7f42a530d069 100644
--- a/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c
+++ b/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c
@@ -540,7 +540,9 @@  SND_SOC_DAILINK_DEFS(playback_hdmi,
 SND_SOC_DAILINK_DEFS(primary_codec,
 		     DAILINK_COMP_ARRAY(COMP_CPU("ADDA")),
 		     DAILINK_COMP_ARRAY(COMP_CODEC("mt6359-sound",
-						   "mt6359-snd-codec-aif1")),
+						   "mt6359-snd-codec-aif1"),
+					COMP_CODEC("dmic-codec",
+						   "dmic-hifi")),
 		     DAILINK_COMP_ARRAY(COMP_EMPTY()));
 
 SND_SOC_DAILINK_DEFS(primary_codec_ch34,