regulator: mt6360: remove redundant error print

Commit Message

Jian Dong March 23, 2021, 12:22 p.m. UTC

From: Jian Dong <[e-mail]>

fixes coccicheck warning:

drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is
redundant because platform_get_irq() already prints an error

in fact, it is not platform_get_irq but platform_get_irq_byname print error

Signed-off-by: Jian Dong <[e-mail]>
---
 drivers/regulator/mt6360-regulator.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Mark Brown March 23, 2021, 5:16 p.m. UTC | #1

On Tue, Mar 23, 2021 at 08:22:41PM +0800, Jian Dong wrote:
> From: Jian Dong <[e-mail]>
> 
> fixes coccicheck warning:
> 
> drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is
> redundant because platform_get_irq() already prints an error

This doesn't apply against current code, please check and resend.

Applying: regulator: mt6360: remove redundant error print
error: sha1 information is lacking or useless (drivers/regulator/mt6360-regulator.c).
error: could not build fake ancestor
Patch failed at 0001 regulator: mt6360: remove redundant error print

Jian Dong March 24, 2021, 1:24 a.m. UTC | #2

On Tue, 23 Mar 2021 17:16:28 +0000
Mark Brown <[e-mail]> wrote:

> On Tue, Mar 23, 2021 at 08:22:41PM +0800, Jian Dong wrote:
> > From: Jian Dong <[e-mail]>
> > 
> > fixes coccicheck warning:
> > 
> > drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is
> > redundant because platform_get_irq() already prints an error  
> 
> This doesn't apply against current code, please check and resend.
> 
> Applying: regulator: mt6360: remove redundant error print
> error: sha1 information is lacking or useless
> (drivers/regulator/mt6360-regulator.c). error: could not build fake
> ancestor Patch failed at 0001 regulator: mt6360: remove redundant
> error print

Hi 

I find the problem, before this patch, I had commit a patch 
"[PATCH]regulator: Use IRQF_ONESHOT", and it hasn't be accepted now, So
the current code is different.

I will modify and resend later.

Mark Brown March 24, 2021, 11:39 p.m. UTC | #3

On Tue, 23 Mar 2021 20:22:41 +0800, Jian Dong wrote:
> fixes coccicheck warning:
> 
> drivers/regulator/mt6360-regulator.c:384:3-10: line 384 is
> redundant because platform_get_irq() already prints an error
> 
> in fact, it is not platform_get_irq but platform_get_irq_byname print error

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: mt6360: remove redundant error print
      commit: f56f2b953bccabb9bd283a734c7e35a1bb1c1ff8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Patch

diff --git a/drivers/regulator/mt6360-regulator.c b/drivers/regulator/mt6360-regulator.c
index 947350d..178180c 100644
--- a/drivers/regulator/mt6360-regulator.c
+++ b/drivers/regulator/mt6360-regulator.c
@@ -380,10 +380,8 @@  static int mt6360_regulator_irq_register(struct platform_device *pdev,
 		const struct mt6360_irq_mapping *irq_desc = tbls + i;
 
 		irq = platform_get_irq_byname(pdev, irq_desc->name);
-		if (irq < 0) {
-			dev_err(&pdev->dev, "Fail to get %s irq\n", irq_desc->name);
+		if (irq < 0)
 			return irq;
-		}
 
 		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler,
 					IRQF_ONESHOT, irq_desc->name, rdev);