| Message ID | 1663157936-5010-1-git-send-email-u0084500@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] dt-bindings: mfd: mt6370: fix the indentation in the example | expand |
On Wed, 14 Sep 2022 20:18:56 +0800, cy_huang wrote: > From: ChiYuan Huang <cy_huang@richtek.com> > > Fix the indentation in the binding example. There're two redudant space > charactors need to be removed. > > Fixes: 76f52f815f1a ("dt-bindings: mfd: Add MediaTek MT6370") > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > --- > Since v2: > - Add Fixes tag in commit message > > --- > Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
Rob Herring <robh@kernel.org> 於 2022年9月15日 週四 晚上9:43寫道： > > On Wed, 14 Sep 2022 20:18:56 +0800, cy_huang wrote: > > From: ChiYuan Huang <cy_huang@richtek.com> > > > > Fix the indentation in the binding example. There're two redudant space > > charactors need to be removed. > > > > Fixes: 76f52f815f1a ("dt-bindings: mfd: Add MediaTek MT6370") > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > > --- > > Since v2: > > - Add Fixes tag in commit message > > > > --- > > Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > I'm not sure about the rule. AngeloGioacchino said I need to add the 'Fixes' tag. I think it might be important. And I immediately submit the v2 patch and add the 'fixes' tag. So patch v3 and add 'Acked-by' tag?
On 15/09/2022 14:56, ChiYuan Huang wrote: >> >> Please add Acked-by/Reviewed-by tags when posting new versions. However, >> there's no need to repost patches *only* to add the tags. The upstream >> maintainer will do that for acks received on the version they apply. >> >> If a tag was not added on purpose, please state why and what changed. >> > I'm not sure about the rule. > AngeloGioacchino said I need to add the 'Fixes' tag. > I think it might be important. > And I immediately submit the v2 patch and add the 'fixes' tag. > So patch v3 and add 'Acked-by' tag? https://lore.kernel.org/all/20220914150620.GA2221443-robh@kernel.org/ https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml index 410e2d4..250484d 100644 --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6370.yaml @@ -119,7 +119,7 @@ examples: #address-cells = <1>; #size-cells = <0>; - pmic@34 { + pmic@34 { compatible = "mediatek,mt6370"; reg = <0x34>; wakeup-source;