diff mbox

[1/2] iommu/mediatek: signedness bug in probe function

Message ID 20160302101006.GF5533@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter March 2, 2016, 10:10 a.m. UTC 
"larb_nr" needs to be signed for the error handling to work.  "i" can
be int as well.

Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Joerg Roedel March 2, 2016, 1:53 p.m. UTC | #1 
On Wed, Mar 02, 2016 at 01:10:06PM +0300, Dan Carpenter wrote:
> "larb_nr" needs to be signed for the error handling to work.  "i" can
> be int as well.
> 
> Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 721ffdb..1a4022c 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -578,7 +578,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
>  	struct resource         *res;
>  	struct component_match  *match = NULL;
>  	void                    *protect;
> -	unsigned int            i, larb_nr;
> +	int			i, larb_nr;
>  	int                     ret;
>  
>  	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);

I merged a similar fix from Andrzej Hajda yesterday.
diff mbox

Patch

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index 721ffdb..1a4022c 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -578,7 +578,7 @@  static int mtk_iommu_probe(struct platform_device *pdev)
 	struct resource         *res;
 	struct component_match  *match = NULL;
 	void                    *protect;
-	unsigned int            i, larb_nr;
+	int			i, larb_nr;
 	int                     ret;
 
 	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);