From patchwork Mon Mar 26 20:38:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 10308655 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B583C600CC for ; Mon, 26 Mar 2018 20:39:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A888A28E16 for ; Mon, 26 Mar 2018 20:39:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9BEA029872; Mon, 26 Mar 2018 20:39:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1772F28E16 for ; Mon, 26 Mar 2018 20:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=YLCbyTU4iGrYSDl2oX5guSAvk0aEXPznhzVQ4Ez39Qk=; b=oNVrBBy21eSxfd+vNhlDaI9BOf SoA/hwlI5mk7+qkE2orP+5AibnJP7WzrlNkCFC+NvMzNb9+d7JssV9678pkSRz3LE35p/ykP5NbLE 6cHCtcn0MvNBgDKcDDfvi7cPTkKbBxeIPkEWnu12UOtwYMtbT8NGPRiUyjHfLZ9zvTQF/aQ9wW1Jt ULx/305+ErRytZCADLUsyzKB6v6xm3gx5eUnvAADDhPak2kh79JVnIfsoIu7efbn17RJ8/Xzp2H3u wqt4DuUefHMaoZ12aWH6Jyt77uAvpEomzrXr0b30QQw3gB7fpC+AC0Bg0IhT57eIpyPb6S7k0ZdV4 7QqQaPMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0Yti-0003Yo-04; Mon, 26 Mar 2018 20:39:18 +0000 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0Yte-0003WH-6D; Mon, 26 Mar 2018 20:39:15 +0000 Received: by mail-wr0-x243.google.com with SMTP id l49so11083061wrl.4; Mon, 26 Mar 2018 13:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rwDNl2FicTyV7ZUj4IF28Rw5ln93D94Ng8gN+4YCTgY=; b=r+3mXH7f4KPpbmGIFPprVtTef9H+N3MKtPHxnrPT8c/yLLpzFcwv+5Ienq/oavrSC1 azP96BULqcp3cNt/1b759uv9591jRymY6AatP4h3QhBrE627MqUUP9ZgDt63V7wb3Cty Ug9r23AbAqVnKJN8Acdd8eW1qZksl7rfurtfpjT+fgykIsSXE43IRE4Vb3iN7e6A28Kc qxzU9PcOWQrZStz2vEvaj+53Gpkh9hyohZGVvLeumM71jgBIQVtQEXrVCyUbKbODEy/z xAZPlaJgnIi6/e9tLwWz5VZHAgvzwX0ssDzW26sy/fCK3o3s4afiUDQT5zxJoOGHv3rl PncA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rwDNl2FicTyV7ZUj4IF28Rw5ln93D94Ng8gN+4YCTgY=; b=tf/ZJzcvX3+dVARQmkG5nxeGrImv5rJ4m6IKXSew9gMW9GEMLC5VfZM5AXjavHKBRL ezSRHUXYlqIw/04TIKsbbrIWjk2KQa9jjzjmgxtfRnoZ1bYk0yElkkUxb9S9swLnQLdO 4zt/6bGSD9GsBpX5/nCDTc9/J/nFsGA9fEpWfef9igeX8dZGza01+Q3PXdjq0VFsW4Zv ujqcS94Y1ols5bwfa2Ba2LxIwSv6WjoIdSbajBgKXJSjjz/DTSmvXVvTuIgwE2zqj9VX plQSUBMk+GnEhU/MWNZnet+Xc21jlyz+IAZZt+0sphPLgql7G+YN9Ijow2CgaB1AQaiX R/mA== X-Gm-Message-State: AElRT7HrLXICE74ZE3KIxuWfmTUDBR5LVydUEkUX3IxSM/1dFSvtGv+k SjOR5rWDFrYsxnJY9YMc2j0= X-Google-Smtp-Source: AG47ELt+PRXRBagrSN/fD3Z2v4sP+vpBuiKUnTUQ4LZL1GWUFLnAdBRTVOk5Iw9yD+OiSc9RgxSjEA== X-Received: by 10.223.225.71 with SMTP id f7mr17776677wri.172.1522096742540; Mon, 26 Mar 2018 13:39:02 -0700 (PDT) Received: from blackbox.darklights.net (p200300DCD741650468A1A7E01A883D6D.dip0.t-ipconnect.de. [2003:dc:d741:6504:68a1:a7e0:1a88:3d6d]) by smtp.googlemail.com with ESMTPSA id m126sm4897040wmf.43.2018.03.26.13.39.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 13:39:01 -0700 (PDT) From: Martin Blumenstingl To: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org Subject: [RFC usb-next v3 1/2] usb: core: split usb_phy_roothub_{init, alloc} Date: Mon, 26 Mar 2018 22:38:45 +0200 Message-Id: <20180326203846.7248-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180326203846.7248-1-martin.blumenstingl@googlemail.com> References: <20180326203846.7248-1-martin.blumenstingl@googlemail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180326_133914_254402_F92BF601 X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: d-gerlach@ti.com, Martin Blumenstingl , j-keerthy@ti.com, stern@rowland.harvard.edu, chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, kishon@ti.com, rogerq@ti.com MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Before this patch usb_phy_roothub_init served two purposes (from a caller's point of view - like hcd.c): - parsing the PHYs and allocating the list entries - calling phy_init on each list entry While this worked so far it has one disadvantage: if we need to call phy_init for each PHY instance then the existing code cannot be re-used. Solve this by splitting off usb_phy_roothub_alloc which only parses the PHYs and allocates the list entries. usb_phy_roothub_init then gets a struct usb_phy_roothub and only calls phy_init on each PHY instance (along with the corresponding cleanup if that failed somewhere). This is a preparation step for adding proper suspend support for some hardware that requires phy_exit to be called during suspend and phy_init to be called during resume. Signed-off-by: Martin Blumenstingl Tested-by: Chunfeng Yun Reviewed-by: Roger Quadros --- drivers/usb/core/hcd.c | 10 +++++++--- drivers/usb/core/phy.c | 53 +++++++++++++++++++++++++------------------------- drivers/usb/core/phy.h | 4 +++- 3 files changed, 37 insertions(+), 30 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 777036ae6367..15b0418e3b6a 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -2758,12 +2758,16 @@ int usb_add_hcd(struct usb_hcd *hcd, } if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) { - hcd->phy_roothub = usb_phy_roothub_init(hcd->self.sysdev); + hcd->phy_roothub = usb_phy_roothub_alloc(hcd->self.sysdev); if (IS_ERR(hcd->phy_roothub)) { retval = PTR_ERR(hcd->phy_roothub); - goto err_phy_roothub_init; + goto err_phy_roothub_alloc; } + retval = usb_phy_roothub_init(hcd->phy_roothub); + if (retval) + goto err_phy_roothub_alloc; + retval = usb_phy_roothub_power_on(hcd->phy_roothub); if (retval) goto err_usb_phy_roothub_power_on; @@ -2936,7 +2940,7 @@ int usb_add_hcd(struct usb_hcd *hcd, usb_phy_roothub_power_off(hcd->phy_roothub); err_usb_phy_roothub_power_on: usb_phy_roothub_exit(hcd->phy_roothub); -err_phy_roothub_init: +err_phy_roothub_alloc: if (hcd->remove_phy && hcd->usb_phy) { usb_phy_shutdown(hcd->usb_phy); usb_put_phy(hcd->usb_phy); diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c index f19aaa3c899c..44f008cda7a8 100644 --- a/drivers/usb/core/phy.c +++ b/drivers/usb/core/phy.c @@ -19,19 +19,6 @@ struct usb_phy_roothub { struct list_head list; }; -static struct usb_phy_roothub *usb_phy_roothub_alloc(struct device *dev) -{ - struct usb_phy_roothub *roothub_entry; - - roothub_entry = devm_kzalloc(dev, sizeof(*roothub_entry), GFP_KERNEL); - if (!roothub_entry) - return ERR_PTR(-ENOMEM); - - INIT_LIST_HEAD(&roothub_entry->list); - - return roothub_entry; -} - static int usb_phy_roothub_add_phy(struct device *dev, int index, struct list_head *list) { @@ -45,9 +32,11 @@ static int usb_phy_roothub_add_phy(struct device *dev, int index, return PTR_ERR(phy); } - roothub_entry = usb_phy_roothub_alloc(dev); - if (IS_ERR(roothub_entry)) - return PTR_ERR(roothub_entry); + roothub_entry = devm_kzalloc(dev, sizeof(*roothub_entry), GFP_KERNEL); + if (!roothub_entry) + return -ENOMEM; + + INIT_LIST_HEAD(&roothub_entry->list); roothub_entry->phy = phy; @@ -56,11 +45,9 @@ static int usb_phy_roothub_add_phy(struct device *dev, int index, return 0; } -struct usb_phy_roothub *usb_phy_roothub_init(struct device *dev) +struct usb_phy_roothub *usb_phy_roothub_alloc(struct device *dev) { struct usb_phy_roothub *phy_roothub; - struct usb_phy_roothub *roothub_entry; - struct list_head *head; int i, num_phys, err; num_phys = of_count_phandle_with_args(dev->of_node, "phys", @@ -68,16 +55,31 @@ struct usb_phy_roothub *usb_phy_roothub_init(struct device *dev) if (num_phys <= 0) return NULL; - phy_roothub = usb_phy_roothub_alloc(dev); - if (IS_ERR(phy_roothub)) - return phy_roothub; + phy_roothub = devm_kzalloc(dev, sizeof(*phy_roothub), GFP_KERNEL); + if (!phy_roothub) + return ERR_PTR(-ENOMEM); + + INIT_LIST_HEAD(&phy_roothub->list); for (i = 0; i < num_phys; i++) { err = usb_phy_roothub_add_phy(dev, i, &phy_roothub->list); if (err) - goto err_out; + return ERR_PTR(err); } + return phy_roothub; +} +EXPORT_SYMBOL_GPL(usb_phy_roothub_alloc); + +int usb_phy_roothub_init(struct usb_phy_roothub *phy_roothub) +{ + struct usb_phy_roothub *roothub_entry; + struct list_head *head; + int err; + + if (!phy_roothub) + return 0; + head = &phy_roothub->list; list_for_each_entry(roothub_entry, head, list) { @@ -86,14 +88,13 @@ struct usb_phy_roothub *usb_phy_roothub_init(struct device *dev) goto err_exit_phys; } - return phy_roothub; + return 0; err_exit_phys: list_for_each_entry_continue_reverse(roothub_entry, head, list) phy_exit(roothub_entry->phy); -err_out: - return ERR_PTR(err); + return err; } EXPORT_SYMBOL_GPL(usb_phy_roothub_init); diff --git a/drivers/usb/core/phy.h b/drivers/usb/core/phy.h index 6fde59bfbff8..eb31253201ad 100644 --- a/drivers/usb/core/phy.h +++ b/drivers/usb/core/phy.h @@ -1,6 +1,8 @@ struct usb_phy_roothub; -struct usb_phy_roothub *usb_phy_roothub_init(struct device *dev); +struct usb_phy_roothub *usb_phy_roothub_alloc(struct device *dev); + +int usb_phy_roothub_init(struct usb_phy_roothub *phy_roothub); int usb_phy_roothub_exit(struct usb_phy_roothub *phy_roothub); int usb_phy_roothub_power_on(struct usb_phy_roothub *phy_roothub);