From patchwork Wed Mar 28 21:18:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Coffey X-Patchwork-Id: 10314169 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3247960325 for ; Wed, 28 Mar 2018 21:20:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20D2B2A067 for ; Wed, 28 Mar 2018 21:20:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F3B42A0BF; Wed, 28 Mar 2018 21:20:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4699B2A067 for ; Wed, 28 Mar 2018 21:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ONu1k+OOQMkP/EmlTDn53rouIR26A1IPwevtuaqILwY=; b=ubr aLitMvygLtweziMCcJPaDV8MPzR6RV99qZCVoKZ6Hear9FHpUlzPV9/NGBHimPFLxo7Exdv4BT9O1 Weq9TUBv3MMKv+0GURA+PEXj1NIGlR0Ba16nyxuYCfAIabR1Chvib7BnAYNT91sDwx9p9Hmti36R8 3Xxk3roI613jNYC1mmw+ZoWuHauxrWirJPmONg/bVnruoVBRU6YJExNqrxevaB+d1A+D7Owprw18G HpHG0QTDkrJLaxr1tXnvo9q4jKZJrW90OE2G8QsVDcH1nEYRmp8n7x+X6Q0kd9W/ev03UWSM2lcwb MWJxCZTj0KVwdR1jQUC1JJNg+biRWew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1IUf-0000NH-KW; Wed, 28 Mar 2018 21:20:29 +0000 Received: from mail.babblebit.net ([37.139.8.208]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1IUB-0007M7-2w; Wed, 28 Mar 2018 21:20:00 +0000 Received: from localhost.localdomain (79-75-32-4.dynamic.dsl.as9105.com [79.75.32.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.babblebit.net (Postfix) with ESMTPSA id 0D1DD12010C; Wed, 28 Mar 2018 21:19:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=babblebit.net; s=mail; t=1522271982; bh=J2kAql4/VZdbenN/xX9QQ6NSVARIF1eyaYdLt8JZlaA=; h=From:To:Cc:Subject:Date:From; b=NBwHopeywIoXDTURMYKel6L07g40E8OBqLpMJENCsqfJmF/7oOfVBLON3TrOAPPEG Jbur2r7Bney0NBovkZVaGrA+yvL7nqxwY3byNek7mKnBuKC3yXByGU53xPu711MKVs Rg+E+NYRVO0Yo1LoOvZN75hrHg9U8RZU3iA9RbNM= From: Chris Coffey To: Greg Kroah-Hartman , NeilBrown , Matthias Brugger Subject: [PATCH] staging: mt7621-eth: Fix sparse warning in ethtool.c Date: Wed, 28 Mar 2018 22:18:48 +0100 Message-Id: <20180328211848.11085-1-cmc@babblebit.net> X-Mailer: git-send-email 2.11.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180328_141959_307824_8F170E51 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Chris Coffey , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Include the local ethtool.h header file in mtk_eth_soc.h so implementation files have centralized access to it. This fixes the following sparse warning: drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static? Signed-off-by: Chris Coffey --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 1 - drivers/staging/mt7621-eth/mtk_eth_soc.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk_eth_soc.c index cbc7339843..0574e71573 100644 --- a/drivers/staging/mt7621-eth/mtk_eth_soc.c +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c @@ -35,7 +35,6 @@ #include "mtk_eth_soc.h" #include "mdio.h" -#include "ethtool.h" #define MAX_RX_LENGTH 1536 #define MTK_RX_ETH_HLEN (VLAN_ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.h b/drivers/staging/mt7621-eth/mtk_eth_soc.h index 443f88d8af..01deeddfdd 100644 --- a/drivers/staging/mt7621-eth/mtk_eth_soc.h +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.h @@ -23,6 +23,7 @@ #include #include #include +#include "ethtool.h" /* these registers have different offsets depending on the SoC. we use a lookup * table for these