From patchwork Thu Mar 29 12:47:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Coffey X-Patchwork-Id: 10315405 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 320B160353 for ; Thu, 29 Mar 2018 12:49:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27FE928514 for ; Thu, 29 Mar 2018 12:49:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1BDF82A337; Thu, 29 Mar 2018 12:49:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9E64B28514 for ; Thu, 29 Mar 2018 12:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=d40a3KAjIRdU2540+ccHVeknoJWCS7OxC/7Yi1bMBd8=; b=YeqLZVbWdD3p80saX7Ak9sfQQg DlZs2qKs8+9TLTpYYzQlHofeXPa0jy94++N6ps/G0jb3GOAdV2t2nWmIxhNdTUWiqXmCaAPdBt88b 5VKx3PypXlc82JKKDvVaitPeR1l5IE5ROpwicBRdWD+4hWjRrRPTbMkE9FiGY5sbIe98RmUk7zCOX L3bWXsTtOwHT03mKLRx40SmTEtg3AfLNsogObWnqW7TRZ3iAT5Si3jNdJd4LYoTnu8+Ui38M/rm19 QiQHn7repfM6pG7GeNcUXGG3EAkUoIBOt5qjqKzuJqZaMIZo+yTLHo2pxxxTPgAbwqz/WtAJvYQDU m7PK0uUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1WzY-0006WI-N4; Thu, 29 Mar 2018 12:49:20 +0000 Received: from mail.babblebit.net ([37.139.8.208]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1WzB-0006Fp-7B; Thu, 29 Mar 2018 12:48:58 +0000 Received: from localhost.localdomain (79-75-32-4.dynamic.dsl.as9105.com [79.75.32.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.babblebit.net (Postfix) with ESMTPSA id 2505412021F; Thu, 29 Mar 2018 12:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=babblebit.net; s=mail; t=1522327724; bh=xfcH3HRbgqdtkNRxJBodT8VfuPzhnFB9Svorz1rGgRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QpKoU/VnmbUfb8+5l2bP9rVdqLGNAXDNiweTZ2H6u3BgkmCwqy+ZKOmvoAkXy8CIh Dkf87s0tU/64rq+nr58AZoFVpfBmqN8FkVcv1dku9AyolS5X+mx29lvp0DZhTFyHvR vT+SPrC5En6grArq97uTbgCLMQNirS97rP9zTIoM= From: Chris Coffey To: Greg Kroah-Hartman , NeilBrown , Matthias Brugger Subject: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c Date: Thu, 29 Mar 2018 13:47:45 +0100 Message-Id: <20180329124745.24694-1-cmc@babblebit.net> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180329095637.GA16778@kroah.com> References: <20180329095637.GA16778@kroah.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180329_054857_402424_E59E57BF X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Chris Coffey , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This fixes the following sparse warning: drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static? Signed-off-by: Chris Coffey Reviewed-by: NeilBrown --- Changes in v2: - Per GregKH's feedback (thanks!), don't add unnecessary new .h file dependencies. This patch version reverts those changes and fixes the problem directly in ethtool.c (which is that it didn't include ethtool.h anywhere -- mtk_set_ethtool_ops is not static). drivers/staging/mt7621-eth/ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/mt7621-eth/ethtool.c b/drivers/staging/mt7621-eth/ethtool.c index 38ba0c040a..5268c5ca09 100644 --- a/drivers/staging/mt7621-eth/ethtool.c +++ b/drivers/staging/mt7621-eth/ethtool.c @@ -13,6 +13,7 @@ */ #include "mtk_eth_soc.h" +#include "ethtool.h" static const char mtk_gdma_str[][ETH_GSTRING_LEN] = { #define _FE(x...) # x,