| Message ID | 20190309095400.26930-2-mussitantesmortem@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging, mt7621: fix build | expand |
On Sat, Mar 09, 2019 at 12:53:59PM +0300, Maxim Zhukov wrote: > Start using new api for linkmode bitmap > > Fixed build after 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode") > > Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com> > --- > drivers/staging/mt7621-eth/mdio.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) This driver is now dropped from the tree, so no need to fix any build issues :) thanks, greg k-h
diff --git a/drivers/staging/mt7621-eth/mdio.c b/drivers/staging/mt7621-eth/mdio.c index 5fea6a447eed..142d7a082dd3 100644 --- a/drivers/staging/mt7621-eth/mdio.c +++ b/drivers/staging/mt7621-eth/mdio.c @@ -89,8 +89,12 @@ int mtk_connect_phy_node(struct mtk_eth *eth, struct mtk_mac *mac, return -ENODEV; } - phydev->supported &= PHY_1000BT_FEATURES; - phydev->advertising = phydev->supported; + linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT, + phydev->supported); + linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT, + phydev->supported); + + linkmode_copy(phydev->advertising, phydev->supported); dev_info(eth->dev, "connected port %d to PHY at %s [uid=%08x, driver=%s]\n", @@ -113,7 +117,9 @@ static void phy_init(struct mtk_eth *eth, struct mtk_mac *mac, phy->speed = 0; phy->duplex = 0; phy_set_max_speed(phy, SPEED_100); - phy->advertising = phy->supported | ADVERTISED_Autoneg; + linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, + phy->advertising); + phy_start_aneg(phy); }
Start using new api for linkmode bitmap Fixed build after 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode") Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com> --- drivers/staging/mt7621-eth/mdio.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)