From patchwork Tue Mar 26 07:44:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Courbot X-Patchwork-Id: 10870577 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A3EC315AC for ; Tue, 26 Mar 2019 07:45:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DEC228D9B for ; Tue, 26 Mar 2019 07:45:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8150C28DE6; Tue, 26 Mar 2019 07:45:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D80F428D9B for ; Tue, 26 Mar 2019 07:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GrWJlN/9hskfFftOMuXYAkxVcDIDoXCe0U9T8XsXINw=; b=MF5WC//plBP4qp LVFSizTXiWvJMWGhKC3Lutza6z1kI4BDXkWTdcazm39bvk6M3qoB95XqaNOKFM0OzKwEdevNsSHjS 8EkCBpeH6T2ombdowknOP/ODzg6ApI5qmls0zC0jPqaxLMH0Em4UPmD/krufn0p8A4uP3WzHHa83Z hKVZeD7YbHM3qxTOZ/n1jLSJQLE/sZM7NPNnAJHUnjmtnx1MPa7cf9LRjOt8XBviSqNZYh6TqsPtF WtBiuuJpCPolJYARV1hLec4FREq8xZBcHfvDVhLXBv/tznbrKbFoP0cSlNfIlUYt1RwirWT7bUPQR kEw1ZsOMJyUiCZqTUuhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8glV-0007Su-GJ; Tue, 26 Mar 2019 07:44:57 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8glR-0007S7-Qi for linux-mediatek@lists.infradead.org; Tue, 26 Mar 2019 07:44:56 +0000 Received: by mail-pl1-x643.google.com with SMTP id q6so1241453pll.4 for ; Tue, 26 Mar 2019 00:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WN5U6KXN7zp8x4sdlZnFG53yaxOCJgECjRiQIMNvhe4=; b=UFOAt6syz/ZSn9uIr/iXNruJy5QF6TB7LHi1oriFBi4EylajNF97/WfREzpHKa82YZ 7AK4IEuXOymOKLSon2OhbPSj+oAjSuIzk2YCUfnkcaWaDoCeiIkLbJwSQ7fRF5u/WnM4 FxE0o4fhSyaKX0O3Mw2JwLkmxLvnSXdMAGBqc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WN5U6KXN7zp8x4sdlZnFG53yaxOCJgECjRiQIMNvhe4=; b=CF3n+sCeCDHMOZNEzcqLN9U/eqaX5pB3OzNG5AEJe6PhjlwV1lTfQlJiSBrjuKBThh Hwx5yEoSfbvlvAD7x0oB3gPlJ0ZB68eHYl8XCXBrQsF3QW6GiOUCJVG1Pm1m4bQj8WZT gHSA8xZQZWORGTdE3xXq6YtyzTvDEAZjlP3RSRlUOgSmLy7YC2wB4oBCdnBlGp/lf0U4 81NaG1q7uExjAcuvRwh87XxIYow4+bq2HpWEWZwIdi7yT0xZPc+sQ3TDsuEDlDVABYCA 1KEL+F8MUxKvGgUhddg943MJFnvoLeaOL7pIxZgKkImPOlxycpv6YlnTn6kujkaPnzKw JHxw== X-Gm-Message-State: APjAAAWEMe3ITHZklG6nFUZVakyZN9/hlcEDXhWYcT0ehGlZE+BgAfRB mFEP3lO1VriCJPfXYcGoWzy/bA== X-Google-Smtp-Source: APXvYqwqCuWrtEbTSXcTCIzjkhkrreh05C7B3xpiMWN2Bew7wwyKI1ojX0PNg+zVbEG7jYLBc9RpFA== X-Received: by 2002:a17:902:e20e:: with SMTP id ce14mr16000701plb.193.1553586293140; Tue, 26 Mar 2019 00:44:53 -0700 (PDT) Received: from acourbot.tok.corp.google.com ([2401:fa00:4:4:9712:8cf1:d0f:7d33]) by smtp.gmail.com with ESMTPSA id p14sm35710708pgn.34.2019.03.26.00.44.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 00:44:52 -0700 (PDT) From: Alexandre Courbot To: Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab Subject: [PATCH] media: mtk-vcodec: remove ready_to_display Date: Tue, 26 Mar 2019 16:44:46 +0900 Message-Id: <20190326074446.123945-1-acourbot@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_004453_862570_17C92484 X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Alexandre Courbot , linux-media@vger.kernel.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This member is never read throughout the code, so remove it. Signed-off-by: Alexandre Courbot --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 ----- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c index e20b340855e7..710dcebb42b3 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c @@ -133,8 +133,6 @@ static struct vb2_buffer *get_display_buffer(struct mtk_vcodec_ctx *ctx) vb2_set_plane_payload(&dstbuf->vb.vb2_buf, 1, ctx->picinfo.c_bs_sz); - dstbuf->ready_to_display = true; - mtk_v4l2_debug(2, "[%d]status=%x queue id=%d to done_list %d", ctx->id, disp_frame_buffer->status, @@ -1122,11 +1120,9 @@ static void vb2ops_vdec_buf_queue(struct vb2_buffer *vb) v4l2_m2m_buf_queue(ctx->m2m_ctx, vb2_v4l2); buf->queued_in_vb2 = true; buf->queued_in_v4l2 = true; - buf->ready_to_display = false; } else { buf->queued_in_vb2 = false; buf->queued_in_v4l2 = true; - buf->ready_to_display = false; } mutex_unlock(&ctx->lock); return; @@ -1253,7 +1249,6 @@ static int vb2ops_vdec_buf_init(struct vb2_buffer *vb) if (vb->vb2_queue->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { buf->used = false; - buf->ready_to_display = false; buf->queued_in_v4l2 = false; } else { buf->lastframe = false; diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h index dc4fc1df63c5..e4984edec4f8 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h @@ -45,7 +45,6 @@ struct vdec_fb { * @list: link list * @used: Capture buffer contain decoded frame data and keep in * codec data structure - * @ready_to_display: Capture buffer not display yet * @queued_in_vb2: Capture buffer is queue in vb2 * @queued_in_v4l2: Capture buffer is in v4l2 driver, but not in vb2 * queue yet @@ -60,7 +59,6 @@ struct mtk_video_dec_buf { struct list_head list; bool used; - bool ready_to_display; bool queued_in_vb2; bool queued_in_v4l2; bool lastframe;