diff mbox series

[RFC,1/1] mtd: rawnand: mtk: Re-license MTK NAND driver as Dual MIT/GPL

Message ID 20190424064522.33501-2-xiaolei.li@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Re-license MTK NAND driver | expand

Commit Message

xiaolei li April 24, 2019, 6:45 a.m. UTC
It is allowed to use MTK NAND driver with GPL-2.0 or MIT license.
But now it is only licensed as GPL-2.0.
So re-license it as dual MIT/GPL.

Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
---
 drivers/mtd/nand/raw/mtk_ecc.c  | 12 ++----------
 drivers/mtd/nand/raw/mtk_ecc.h  |  4 +---
 drivers/mtd/nand/raw/mtk_nand.c | 12 ++----------
 3 files changed, 5 insertions(+), 23 deletions(-)

Comments

Richard Weinberger April 24, 2019, 7:29 a.m. UTC | #1
Am Mittwoch, 24. April 2019, 08:45:22 CEST schrieb Xiaolei Li:
> It is allowed to use MTK NAND driver with GPL-2.0 or MIT license.
> But now it is only licensed as GPL-2.0.
> So re-license it as dual MIT/GPL.

I fear this needs ACKs from all authors and major contributors of the driver
before we can apply such a change.

Thanks,
//richard
xiaolei li April 24, 2019, 8:25 a.m. UTC | #2
Hi Richard,

On Wed, 2019-04-24 at 09:29 +0200, Richard Weinberger wrote:
> Am Mittwoch, 24. April 2019, 08:45:22 CEST schrieb Xiaolei Li:
> > It is allowed to use MTK NAND driver with GPL-2.0 or MIT license.
> > But now it is only licensed as GPL-2.0.
> > So re-license it as dual MIT/GPL.
> 
> I fear this needs ACKs from all authors and major contributors of the driver
> before we can apply such a change.

Yes. MTK wants to solicit ACKs for this change from copyrights holders
here.
I added another driver author Jorge, and let's wait for the response.

Thanks,
Xiaolei
> 
> Thanks,
> //richard
> 
>
Matthias Brugger April 24, 2019, 1:15 p.m. UTC | #3
On 24/04/2019 10:25, xiaolei li wrote:
> Hi Richard,
> 
> On Wed, 2019-04-24 at 09:29 +0200, Richard Weinberger wrote:
>> Am Mittwoch, 24. April 2019, 08:45:22 CEST schrieb Xiaolei Li:
>>> It is allowed to use MTK NAND driver with GPL-2.0 or MIT license.
>>> But now it is only licensed as GPL-2.0.
>>> So re-license it as dual MIT/GPL.
>>
>> I fear this needs ACKs from all authors and major contributors of the driver
>> before we can apply such a change.
> 
> Yes. MTK wants to solicit ACKs for this change from copyrights holders
> here.
> I added another driver author Jorge, and let's wait for the response.
> 

You are missing at least Ryder Lee, Rafał Miłecki and Wen Yang in the CC list.
I think it would be good to understand why you want to distribute the driver
under MIT license.

Regards,
Matthias
Jorge Ramirez-Ortiz April 24, 2019, 4:15 p.m. UTC | #4
On 4/24/19 08:45, Xiaolei Li wrote:
> It is allowed to use MTK NAND driver with GPL-2.0 or MIT license.
> But now it is only licensed as GPL-2.0.
> So re-license it as dual MIT/GPL.

Relicensing is OK with respect to any Linaro copyright interest deriving
from upstreaming this work.

Acked-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>

> 
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
> ---
>  drivers/mtd/nand/raw/mtk_ecc.c  | 12 ++----------
>  drivers/mtd/nand/raw/mtk_ecc.h  |  4 +---
>  drivers/mtd/nand/raw/mtk_nand.c | 12 ++----------
>  3 files changed, 5 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/mtk_ecc.c b/drivers/mtd/nand/raw/mtk_ecc.c
> index 6432bd70c3b3..eea0f903bc24 100644
> --- a/drivers/mtd/nand/raw/mtk_ecc.c
> +++ b/drivers/mtd/nand/raw/mtk_ecc.c
> @@ -1,17 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>  /*
>   * MTK ECC controller driver.
>   * Copyright (C) 2016  MediaTek Inc.
>   * Authors:	Xiaolei Li		<xiaolei.li@mediatek.com>
>   *		Jorge Ramirez-Ortiz	<jorge.ramirez-ortiz@linaro.org>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
>   */
>  
>  #include <linux/platform_device.h>
> @@ -600,4 +592,4 @@ module_platform_driver(mtk_ecc_driver);
>  
>  MODULE_AUTHOR("Xiaolei Li <xiaolei.li@mediatek.com>");
>  MODULE_DESCRIPTION("MTK Nand ECC Driver");
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("Dual MIT/GPL");
> diff --git a/drivers/mtd/nand/raw/mtk_ecc.h b/drivers/mtd/nand/raw/mtk_ecc.h
> index a455df080952..0e48c36e6ca0 100644
> --- a/drivers/mtd/nand/raw/mtk_ecc.h
> +++ b/drivers/mtd/nand/raw/mtk_ecc.h
> @@ -1,12 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR MIT */
>  /*
>   * MTK SDG1 ECC controller
>   *
>   * Copyright (c) 2016 Mediatek
>   * Authors:	Xiaolei Li		<xiaolei.li@mediatek.com>
>   *		Jorge Ramirez-Ortiz	<jorge.ramirez-ortiz@linaro.org>
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License version 2 as published
> - * by the Free Software Foundation.
>   */
>  
>  #ifndef __DRIVERS_MTD_NAND_MTK_ECC_H__
> diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
> index b6b4602f5132..3cbc25793062 100644
> --- a/drivers/mtd/nand/raw/mtk_nand.c
> +++ b/drivers/mtd/nand/raw/mtk_nand.c
> @@ -1,17 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>  /*
>   * MTK NAND Flash controller driver.
>   * Copyright (C) 2016 MediaTek Inc.
>   * Authors:	Xiaolei Li		<xiaolei.li@mediatek.com>
>   *		Jorge Ramirez-Ortiz	<jorge.ramirez-ortiz@linaro.org>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
>   */
>  
>  #include <linux/platform_device.h>
> @@ -1598,6 +1590,6 @@ static struct platform_driver mtk_nfc_driver = {
>  
>  module_platform_driver(mtk_nfc_driver);
>  
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("Dual MIT/GPL");
>  MODULE_AUTHOR("Xiaolei Li <xiaolei.li@mediatek.com>");
>  MODULE_DESCRIPTION("MTK Nand Flash Controller Driver");
>
xiaolei li April 25, 2019, 1:12 a.m. UTC | #5
Hi Matthias,

On Wed, 2019-04-24 at 15:15 +0200, Matthias Brugger wrote:
> 
> On 24/04/2019 10:25, xiaolei li wrote:
> > Hi Richard,
> > 
> > On Wed, 2019-04-24 at 09:29 +0200, Richard Weinberger wrote:
> >> Am Mittwoch, 24. April 2019, 08:45:22 CEST schrieb Xiaolei Li:
> >>> It is allowed to use MTK NAND driver with GPL-2.0 or MIT license.
> >>> But now it is only licensed as GPL-2.0.
> >>> So re-license it as dual MIT/GPL.
> >>
> >> I fear this needs ACKs from all authors and major contributors of the driver
> >> before we can apply such a change.
> > 
> > Yes. MTK wants to solicit ACKs for this change from copyrights holders
> > here.
> > I added another driver author Jorge, and let's wait for the response.
> > 
> 
> You are missing at least Ryder Lee, Rafał Miłecki and Wen Yang in the CC list.
Thanks for your reminding. I will add them in next patch version.

> I think it would be good to understand why you want to distribute the driver
> under MIT license.
MTK wants to modify and publish this driver with MIT license in
bootloader. So, here we ask for ACKs whether we can re-license it as
dual MIT/GPL.

Thanks,
Xiaolei
> 
> Regards,
> Matthias
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/mtk_ecc.c b/drivers/mtd/nand/raw/mtk_ecc.c
index 6432bd70c3b3..eea0f903bc24 100644
--- a/drivers/mtd/nand/raw/mtk_ecc.c
+++ b/drivers/mtd/nand/raw/mtk_ecc.c
@@ -1,17 +1,9 @@ 
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * MTK ECC controller driver.
  * Copyright (C) 2016  MediaTek Inc.
  * Authors:	Xiaolei Li		<xiaolei.li@mediatek.com>
  *		Jorge Ramirez-Ortiz	<jorge.ramirez-ortiz@linaro.org>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <linux/platform_device.h>
@@ -600,4 +592,4 @@  module_platform_driver(mtk_ecc_driver);
 
 MODULE_AUTHOR("Xiaolei Li <xiaolei.li@mediatek.com>");
 MODULE_DESCRIPTION("MTK Nand ECC Driver");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual MIT/GPL");
diff --git a/drivers/mtd/nand/raw/mtk_ecc.h b/drivers/mtd/nand/raw/mtk_ecc.h
index a455df080952..0e48c36e6ca0 100644
--- a/drivers/mtd/nand/raw/mtk_ecc.h
+++ b/drivers/mtd/nand/raw/mtk_ecc.h
@@ -1,12 +1,10 @@ 
+/* SPDX-License-Identifier: GPL-2.0 OR MIT */
 /*
  * MTK SDG1 ECC controller
  *
  * Copyright (c) 2016 Mediatek
  * Authors:	Xiaolei Li		<xiaolei.li@mediatek.com>
  *		Jorge Ramirez-Ortiz	<jorge.ramirez-ortiz@linaro.org>
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published
- * by the Free Software Foundation.
  */
 
 #ifndef __DRIVERS_MTD_NAND_MTK_ECC_H__
diff --git a/drivers/mtd/nand/raw/mtk_nand.c b/drivers/mtd/nand/raw/mtk_nand.c
index b6b4602f5132..3cbc25793062 100644
--- a/drivers/mtd/nand/raw/mtk_nand.c
+++ b/drivers/mtd/nand/raw/mtk_nand.c
@@ -1,17 +1,9 @@ 
+// SPDX-License-Identifier: GPL-2.0 OR MIT
 /*
  * MTK NAND Flash controller driver.
  * Copyright (C) 2016 MediaTek Inc.
  * Authors:	Xiaolei Li		<xiaolei.li@mediatek.com>
  *		Jorge Ramirez-Ortiz	<jorge.ramirez-ortiz@linaro.org>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
 
 #include <linux/platform_device.h>
@@ -1598,6 +1590,6 @@  static struct platform_driver mtk_nfc_driver = {
 
 module_platform_driver(mtk_nfc_driver);
 
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("Dual MIT/GPL");
 MODULE_AUTHOR("Xiaolei Li <xiaolei.li@mediatek.com>");
 MODULE_DESCRIPTION("MTK Nand Flash Controller Driver");