| Message ID | 20190527083150.220194-2-tientzu@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | support 8250-mtk uart in-band wake up | expand |
(cc-ed device tree maintainers and mailing list) The second patch in this series[1] is already in tty-next[2]. Sorry for not cc-ing device tree maintainers/mailing list at the beginning. I can resend this patch if needed. Thanks. [1] https://patchwork.kernel.org/patch/10962299/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/log/?h=tty-testing
On Tue, Jun 11, 2019 at 05:53:54PM +0800, Claire Chang wrote: > (cc-ed device tree maintainers and mailing list) > > The second patch in this series[1] is already in tty-next[2]. > > Sorry for not cc-ing device tree maintainers/mailing list at the beginning. > I can resend this patch if needed. Please do, as it is not here for them to review :( greg k-h
resent here: https://patchwork.ozlabs.org/patch/1113768/ sorry for the inconvenience
diff --git a/Documentation/devicetree/bindings/serial/mtk-uart.txt b/Documentation/devicetree/bindings/serial/mtk-uart.txt index c6b5262eb352..11966de2a4b3 100644 --- a/Documentation/devicetree/bindings/serial/mtk-uart.txt +++ b/Documentation/devicetree/bindings/serial/mtk-uart.txt @@ -23,7 +23,12 @@ Required properties: - reg: The base address of the UART register bank. -- interrupts: A single interrupt specifier. +- interrupts or interrupts-extended: + index 0: an interrupt specifier for the UART controller itself + index 1: optional, an interrupt specifier with edge sensitivity on Rx pin to + support Rx in-band wake up. If one would like to use this feature, + one must create an addtional pinctrl to reconfigure Rx pin to normal + GPIO before suspend. - clocks : Must contain an entry for each entry in clock-names. See ../clocks/clock-bindings.txt for details. @@ -39,7 +44,11 @@ Example: uart0: serial@11006000 { compatible = "mediatek,mt6589-uart", "mediatek,mt6577-uart"; reg = <0x11006000 0x400>; - interrupts = <GIC_SPI 51 IRQ_TYPE_LEVEL_LOW>; + interrupts-extended = <&sysirq GIC_SPI 51 IRQ_TYPE_LEVEL_LOW>, + <&gpio 121 IRQ_TYPE_EDGE_FALLING>; clocks = <&uart_clk>, <&bus_clk>; clock-names = "baud", "bus"; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&uart_pin>; + pinctrl-1 = <&uart_pin_sleep>; };
To support Rx in-band wakeup, one must create an interrupt specifier with edge sensitivity on Rx pin and an addtional pinctrl to reconfigure Rx pin to normal GPIO in sleep state. Driver will switch to sleep mode pinctrl and enable irq wake before suspend and restore to default settings when resuming. Signed-off-by: Claire Chang <tientzu@chromium.org> --- .../devicetree/bindings/serial/mtk-uart.txt | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)