| Message ID | 20191006102953.57536-17-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rtc: use devm_platform_ioremap_resource() to simplify code | expand |
YueHaibing <yuehaibing@huawei.com> writes: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Kevin Hilman <khilman@baylibre.com> > --- > drivers/rtc/rtc-meson.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c > index e08b981..9bd8478 100644 > --- a/drivers/rtc/rtc-meson.c > +++ b/drivers/rtc/rtc-meson.c > @@ -292,7 +292,6 @@ static int meson_rtc_probe(struct platform_device *pdev) > }; > struct device *dev = &pdev->dev; > struct meson_rtc *rtc; > - struct resource *res; > void __iomem *base; > int ret; > u32 tm; > @@ -312,8 +311,7 @@ static int meson_rtc_probe(struct platform_device *pdev) > rtc->rtc->ops = &meson_rtc_ops; > rtc->rtc->range_max = U32_MAX; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(dev, res); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); > > -- > 2.7.4
On Sun, Oct 6, 2019 at 12:38 PM YueHaibing <yuehaibing@huawei.com> wrote: > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> thank you for taking care of this! Martin
diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index e08b981..9bd8478 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -292,7 +292,6 @@ static int meson_rtc_probe(struct platform_device *pdev) }; struct device *dev = &pdev->dev; struct meson_rtc *rtc; - struct resource *res; void __iomem *base; int ret; u32 tm; @@ -312,8 +311,7 @@ static int meson_rtc_probe(struct platform_device *pdev) rtc->rtc->ops = &meson_rtc_ops; rtc->rtc->range_max = U32_MAX; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - base = devm_ioremap_resource(dev, res); + base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(base)) return PTR_ERR(base);
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/rtc/rtc-meson.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)