| Message ID | 20200103064407.19861-3-michael.kao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Mediatek thermal dirver and dtsi | expand |
On 03/01/2020 07:44, Michael Kao wrote: > From: "michael.kao" <michael.kao@mediatek.com> > > Add dynamic power coefficients for all cores and update those of > CPU0 and CPU4. No update in this patch. I suppose it need rewording. Regards, Matthias > > Signed-off-by: Michael Kao <michael.kao@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index a2793cf3d994..cfb74af260e0 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -73,6 +73,7 @@ > reg = <0x000>; > enable-method = "psci"; > capacity-dmips-mhz = <741>; > + dynamic-power-coefficient = <84>; > }; > > cpu1: cpu@1 { > @@ -81,6 +82,7 @@ > reg = <0x001>; > enable-method = "psci"; > capacity-dmips-mhz = <741>; > + dynamic-power-coefficient = <84>; > }; > > cpu2: cpu@2 { > @@ -89,6 +91,7 @@ > reg = <0x002>; > enable-method = "psci"; > capacity-dmips-mhz = <741>; > + dynamic-power-coefficient = <84>; > }; > > cpu3: cpu@3 { > @@ -97,6 +100,7 @@ > reg = <0x003>; > enable-method = "psci"; > capacity-dmips-mhz = <741>; > + dynamic-power-coefficient = <84>; > }; > > cpu4: cpu@100 { > @@ -105,6 +109,7 @@ > reg = <0x100>; > enable-method = "psci"; > capacity-dmips-mhz = <1024>; > + dynamic-power-coefficient = <211>; > }; > > cpu5: cpu@101 { > @@ -113,6 +118,7 @@ > reg = <0x101>; > enable-method = "psci"; > capacity-dmips-mhz = <1024>; > + dynamic-power-coefficient = <211>; > }; > > cpu6: cpu@102 { > @@ -121,6 +127,7 @@ > reg = <0x102>; > enable-method = "psci"; > capacity-dmips-mhz = <1024>; > + dynamic-power-coefficient = <211>; > }; > > cpu7: cpu@103 { > @@ -129,6 +136,7 @@ > reg = <0x103>; > enable-method = "psci"; > capacity-dmips-mhz = <1024>; > + dynamic-power-coefficient = <211>; > }; > }; > >
On Fri, 2020-01-10 at 15:40 +0100, Matthias Brugger wrote:
> I suppose it need rewording.
Hi Matthias,
This patch was resent following with the patch series,Add Mediatek
thermal driver and dtsi.
I have write all the changes in the cover letter.
There is no change in this patch.
Do you mean that I need to add some word to commit message or
change the dynamic power coefficients?
Best Regards,
Michael Kao
On 11/02/2020 03:05, Michael Kao wrote: > On Fri, 2020-01-10 at 15:40 +0100, Matthias Brugger wrote: >> I suppose it need rewording. > > Hi Matthias, > > This patch was resent following with the patch series,Add Mediatek > thermal driver and dtsi. > I have write all the changes in the cover letter. > There is no change in this patch. > > Do you mean that I need to add some word to commit message or > change the dynamic power coefficients? > Your commit message says: "Add dynamic power coefficients for all cores and update those of CPU0 and CPU4." But the power coefficients for CPU0-4 are not updated, but added. I fixed the commit message and pushed to v5.6-next/dts64 Please double check that everything is correct. Regards, Matthias
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index a2793cf3d994..cfb74af260e0 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -73,6 +73,7 @@ reg = <0x000>; enable-method = "psci"; capacity-dmips-mhz = <741>; + dynamic-power-coefficient = <84>; }; cpu1: cpu@1 { @@ -81,6 +82,7 @@ reg = <0x001>; enable-method = "psci"; capacity-dmips-mhz = <741>; + dynamic-power-coefficient = <84>; }; cpu2: cpu@2 { @@ -89,6 +91,7 @@ reg = <0x002>; enable-method = "psci"; capacity-dmips-mhz = <741>; + dynamic-power-coefficient = <84>; }; cpu3: cpu@3 { @@ -97,6 +100,7 @@ reg = <0x003>; enable-method = "psci"; capacity-dmips-mhz = <741>; + dynamic-power-coefficient = <84>; }; cpu4: cpu@100 { @@ -105,6 +109,7 @@ reg = <0x100>; enable-method = "psci"; capacity-dmips-mhz = <1024>; + dynamic-power-coefficient = <211>; }; cpu5: cpu@101 { @@ -113,6 +118,7 @@ reg = <0x101>; enable-method = "psci"; capacity-dmips-mhz = <1024>; + dynamic-power-coefficient = <211>; }; cpu6: cpu@102 { @@ -121,6 +127,7 @@ reg = <0x102>; enable-method = "psci"; capacity-dmips-mhz = <1024>; + dynamic-power-coefficient = <211>; }; cpu7: cpu@103 { @@ -129,6 +136,7 @@ reg = <0x103>; enable-method = "psci"; capacity-dmips-mhz = <1024>; + dynamic-power-coefficient = <211>; }; };