| Message ID | 20200115135958.126303-2-jitao.shi@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels | expand |
Hi Jitao. A few comments that I missed in last round. Please consider to combine the three panels in one binding. I realise they are almost identical so no need for three binding files. On Wed, Jan 15, 2020 at 09:59:51PM +0800, Jitao Shi wrote: > Add documentation for boe tv101wum-n16 panel. > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > --- > .../display/panel/boe,tv101wum-nl6.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > new file mode 100644 > index 000000000000..d38aee22d406 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: GPL-2.0 Please use (GPL-2.0-only OR BSD-2-Clause) for all new bindings. (Sorry if this was not part of my previous feedback) Sam > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/boe,tv101wum-nl6.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: BOE TV101WUM-Nl6 DSI Display Panel > + > +maintainers: > + - Thierry Reding <thierry.reding@gmail.com> > + - Sam Ravnborg <sam@ravnborg.org> > + - Rob Herring <robh+dt@kernel.org> Rob is not a typical maintainer of panel bindings. The fallback it Thierry and me. But if you have agreed this with Rob then all is good. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: boe,tv101wum-nl6 > + > + reg: > + description: the virtual channel number of a DSI peripheral > + > + enable-gpios: > + description: a GPIO spec for the enable pin > + > + pp1800-supply: > + description: core voltage supply > + > + avdd-supply: > + description: phandle of the regulator that provides positive voltage > + > + avee-supply: > + description: phandle of the regulator that provides negative voltage > + > + backlight: > + description: phandle of the backlight device attached to the panel > + > + port: true > + > +required: > + - compatible > + - reg > + - enable-gpios > + - pp1800-supply > + - avdd-supply > + - avee-supply > + - backlight I would be suprised if backlight is a required node. You could always tie the input to a fixed voltage and then no backlight node are required. Please remove from the required list unless you can convince me otherwise. Sam > + > +additionalProperties: false > + > +examples: > + - | > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "boe,tv101wum-nl6"; > + reg = <0>; > + enable-gpios = <&pio 45 0>; > + avdd-supply = <&ppvarn_lcd>; > + avee-supply = <&ppvarp_lcd>; > + pp1800-supply = <&pp1800_lcd>; > + backlight = <&backlight_lcd0>; > + status = "okay"; > + port { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > + }; > + > +... > -- > 2.21.0
diff --git a/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml new file mode 100644 index 000000000000..d38aee22d406 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/boe,tv101wum-nl6.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: BOE TV101WUM-Nl6 DSI Display Panel + +maintainers: + - Thierry Reding <thierry.reding@gmail.com> + - Sam Ravnborg <sam@ravnborg.org> + - Rob Herring <robh+dt@kernel.org> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: boe,tv101wum-nl6 + + reg: + description: the virtual channel number of a DSI peripheral + + enable-gpios: + description: a GPIO spec for the enable pin + + pp1800-supply: + description: core voltage supply + + avdd-supply: + description: phandle of the regulator that provides positive voltage + + avee-supply: + description: phandle of the regulator that provides negative voltage + + backlight: + description: phandle of the backlight device attached to the panel + + port: true + +required: + - compatible + - reg + - enable-gpios + - pp1800-supply + - avdd-supply + - avee-supply + - backlight + +additionalProperties: false + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "boe,tv101wum-nl6"; + reg = <0>; + enable-gpios = <&pio 45 0>; + avdd-supply = <&ppvarn_lcd>; + avee-supply = <&ppvarp_lcd>; + pp1800-supply = <&pp1800_lcd>; + backlight = <&backlight_lcd0>; + status = "okay"; + port { + panel_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + }; + }; + +...