| Message ID | 20200323121537.22697-6-michael.kao@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Mediatek thermal dirver and dtsi | expand |
On 23/03/2020 13:15, Michael Kao wrote: > MT8183_NUM_ZONES should be set to 1 > because MT8183 doesn't have multiple banks. Apparently this is a hot fix. Can you confirm and explain what is the procedure to hit the bug? I'll pick it for the next -rc if possible > Fixes: a4ffe6b52d27 ("thermal: mediatek: add support for MT8183") > Signed-off-by: Michael Kao <michael.kao@mediatek.com> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > drivers/thermal/mtk_thermal.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c > index 76e30603d4d5..6b7ef1993d7e 100644 > --- a/drivers/thermal/mtk_thermal.c > +++ b/drivers/thermal/mtk_thermal.c > @@ -211,6 +211,9 @@ enum { > /* The total number of temperature sensors in the MT8183 */ > #define MT8183_NUM_SENSORS 6 > > +/* The number of banks in the MT8183 */ > +#define MT8183_NUM_ZONES 1 > + > /* The number of sensing points per bank */ > #define MT8183_NUM_SENSORS_PER_ZONE 6 > > @@ -497,7 +500,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { > */ > static const struct mtk_thermal_data mt8183_thermal_data = { > .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, > - .num_banks = MT8183_NUM_SENSORS_PER_ZONE, > + .num_banks = MT8183_NUM_ZONES, > .num_sensors = MT8183_NUM_SENSORS, > .vts_index = mt8183_vts_index, > .cali_val = MT8183_CALIBRATION, >
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index 76e30603d4d5..6b7ef1993d7e 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -211,6 +211,9 @@ enum { /* The total number of temperature sensors in the MT8183 */ #define MT8183_NUM_SENSORS 6 +/* The number of banks in the MT8183 */ +#define MT8183_NUM_ZONES 1 + /* The number of sensing points per bank */ #define MT8183_NUM_SENSORS_PER_ZONE 6 @@ -497,7 +500,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { */ static const struct mtk_thermal_data mt8183_thermal_data = { .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, - .num_banks = MT8183_NUM_SENSORS_PER_ZONE, + .num_banks = MT8183_NUM_ZONES, .num_sensors = MT8183_NUM_SENSORS, .vts_index = mt8183_vts_index, .cali_val = MT8183_CALIBRATION,
MT8183_NUM_ZONES should be set to 1 because MT8183 doesn't have multiple banks. Fixes: a4ffe6b52d27 ("thermal: mediatek: add support for MT8183") Signed-off-by: Michael Kao <michael.kao@mediatek.com> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- drivers/thermal/mtk_thermal.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)