| Message ID | 20200429071337.49528-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,-next] drm/mediatek: Fix Kconfig warning | expand |
Hi YueHaibing, Thank you for your patch. On 29/4/20 9:13, YueHaibing wrote: > WARNING: unmet direct dependencies detected for MTK_MMSYS > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n] > Selected by [y]: > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] > > Make DRM_MEDIATEK depend on MTK_MMSYS to fix this. > > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Definitively we shouldn't select the MTK_MMSYS and we should depend on MTK_MMSYS instead, so Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > v3: make DRM_MEDIATEK depends on MTK_MMSYS > v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency > --- > drivers/gpu/drm/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index c420f5a3d33b..aa74aac3cbcc 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -6,12 +6,12 @@ config DRM_MEDIATEK > depends on COMMON_CLK > depends on HAVE_ARM_SMCCC > depends on OF > + depends on MTK_MMSYS > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL > select MEMORY > - select MTK_MMSYS > select MTK_SMI > select VIDEOMODE_HELPERS > help >
Hi, YueHaibing: YueHaibing <yuehaibing@huawei.com> 於 2020年4月29日 週三 下午3:14寫道： > > WARNING: unmet direct dependencies detected for MTK_MMSYS > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n] > Selected by [y]: > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] > > Make DRM_MEDIATEK depend on MTK_MMSYS to fix this. Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v3: make DRM_MEDIATEK depends on MTK_MMSYS > v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency > --- > drivers/gpu/drm/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index c420f5a3d33b..aa74aac3cbcc 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -6,12 +6,12 @@ config DRM_MEDIATEK > depends on COMMON_CLK > depends on HAVE_ARM_SMCCC > depends on OF > + depends on MTK_MMSYS > select DRM_GEM_CMA_HELPER > select DRM_KMS_HELPER > select DRM_MIPI_DSI > select DRM_PANEL > select MEMORY > - select MTK_MMSYS > select MTK_SMI > select VIDEOMODE_HELPERS > help > -- > 2.17.1 > >
Hi, YueHaibing: Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2020年4月29日 週三 下午10:15寫道： > > Hi, YueHaibing: > > YueHaibing <yuehaibing@huawei.com> 於 2020年4月29日 週三 下午3:14寫道： > > > > WARNING: unmet direct dependencies detected for MTK_MMSYS > > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n] > > Selected by [y]: > > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] > > > > Make DRM_MEDIATEK depend on MTK_MMSYS to fix this. > > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > > > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > --- > > v3: make DRM_MEDIATEK depends on MTK_MMSYS > > v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency > > --- > > drivers/gpu/drm/mediatek/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > > index c420f5a3d33b..aa74aac3cbcc 100644 > > --- a/drivers/gpu/drm/mediatek/Kconfig > > +++ b/drivers/gpu/drm/mediatek/Kconfig > > @@ -6,12 +6,12 @@ config DRM_MEDIATEK > > depends on COMMON_CLK > > depends on HAVE_ARM_SMCCC > > depends on OF > > + depends on MTK_MMSYS > > select DRM_GEM_CMA_HELPER > > select DRM_KMS_HELPER > > select DRM_MIPI_DSI > > select DRM_PANEL > > select MEMORY > > - select MTK_MMSYS > > select MTK_SMI > > select VIDEOMODE_HELPERS > > help > > -- > > 2.17.1 > > > >
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index c420f5a3d33b..aa74aac3cbcc 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -6,12 +6,12 @@ config DRM_MEDIATEK depends on COMMON_CLK depends on HAVE_ARM_SMCCC depends on OF + depends on MTK_MMSYS select DRM_GEM_CMA_HELPER select DRM_KMS_HELPER select DRM_MIPI_DSI select DRM_PANEL select MEMORY - select MTK_MMSYS select MTK_SMI select VIDEOMODE_HELPERS help
WARNING: unmet direct dependencies detected for MTK_MMSYS Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n] Selected by [y]: - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y] Make DRM_MEDIATEK depend on MTK_MMSYS to fix this. Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v3: make DRM_MEDIATEK depends on MTK_MMSYS v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency --- drivers/gpu/drm/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)