| Message ID | 20200530141200.4616-1-stanley.chu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | scsi: ufs: Remove redundant urgent_bkop_lvl initialization | expand |
> > In ufshcd_probe_hba(), all BKOP SW tracking variables can be reset > together in ufshcd_force_reset_auto_bkops(), thus urgent_bkop_lvl > initialization in the beginning of ufshcd_probe_hba() can be merged > into ufshcd_force_reset_auto_bkops(). > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> Reviewed-by: Avri Altman <avri.altman@wdc.com>
On Sat, 30 May 2020 22:12:00 +0800, Stanley Chu wrote: > In ufshcd_probe_hba(), all BKOP SW tracking variables can be reset > together in ufshcd_force_reset_auto_bkops(), thus urgent_bkop_lvl > initialization in the beginning of ufshcd_probe_hba() can be merged > into ufshcd_force_reset_auto_bkops(). Applied to 5.8/scsi-queue, thanks! [1/1] scsi: ufs: Remove redundant urgent_bkop_lvl initialization https://git.kernel.org/mkp/scsi/c/7b6668d8b806
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 5db18f444ea9..f11be69e50e9 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5076,6 +5076,7 @@ static void ufshcd_force_reset_auto_bkops(struct ufs_hba *hba) hba->ee_ctrl_mask &= ~MASK_EE_URGENT_BKOPS; ufshcd_disable_auto_bkops(hba); } + hba->urgent_bkops_lvl = BKOPS_STATUS_PERF_IMPACT; hba->is_urgent_bkops_lvl_checked = false; } @@ -7373,10 +7374,6 @@ static int ufshcd_probe_hba(struct ufs_hba *hba, bool async) if (ret) goto out; - /* set the default level for urgent bkops */ - hba->urgent_bkops_lvl = BKOPS_STATUS_PERF_IMPACT; - hba->is_urgent_bkops_lvl_checked = false; - /* Debug counters initialization */ ufshcd_clear_dbg_ufs_stats(hba);
In ufshcd_probe_hba(), all BKOP SW tracking variables can be reset together in ufshcd_force_reset_auto_bkops(), thus urgent_bkop_lvl initialization in the beginning of ufshcd_probe_hba() can be merged into ufshcd_force_reset_auto_bkops(). Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> --- drivers/scsi/ufs/ufshcd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)