diff mbox series

arm64: dts: mt8173: Re-measure capacity-dmips-mhz

Message ID 20200706083705.2343150-1-hsinyi@chromium.org (mailing list archive)
State New, archived
Headers show
Series arm64: dts: mt8173: Re-measure capacity-dmips-mhz | expand

Commit Message

Hsin-Yi Wang July 6, 2020, 8:37 a.m. UTC
Re measure capacity-dmips-mhz on elm and hana:

cpu 1:  9502 DMIPS @ 1703 Mhz
cpu 3: 16250 DMIPS @ 2106 Mhz

==> 740 : 1024

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Matthias Brugger July 8, 2020, 5:01 p.m. UTC | #1
On 06/07/2020 10:37, Hsin-Yi Wang wrote:
> Re measure capacity-dmips-mhz on elm and hana:
> 
> cpu 1:  9502 DMIPS @ 1703 Mhz
> cpu 3: 16250 DMIPS @ 2106 Mhz
> 
> ==> 740 : 1024

I have some trouble to match the commit message to the actual patch. Commit 
message talks about cpu 1 but patch changes cpu0. Where are the values of the 
other CPUs?

Regards,
Matthias

> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>   arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 70b1ffcab7f0..5e046f9d48ce 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -167,7 +167,7 @@ cpu0: cpu@0 {
>   				 <&apmixedsys CLK_APMIXED_MAINPLL>;
>   			clock-names = "cpu", "intermediate";
>   			operating-points-v2 = <&cluster0_opp>;
> -			capacity-dmips-mhz = <526>;
> +			capacity-dmips-mhz = <740>;
>   		};
>   
>   		cpu1: cpu@1 {
> @@ -182,7 +182,7 @@ cpu1: cpu@1 {
>   				 <&apmixedsys CLK_APMIXED_MAINPLL>;
>   			clock-names = "cpu", "intermediate";
>   			operating-points-v2 = <&cluster0_opp>;
> -			capacity-dmips-mhz = <526>;
> +			capacity-dmips-mhz = <740>;
>   		};
>   
>   		cpu2: cpu@100 {
>
Hsin-Yi Wang July 8, 2020, 6:55 p.m. UTC | #2
On Thu, Jul 9, 2020 at 1:01 AM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>
>
>
> On 06/07/2020 10:37, Hsin-Yi Wang wrote:
> > Re measure capacity-dmips-mhz on elm and hana:
> >
> > cpu 1:  9502 DMIPS @ 1703 Mhz
> > cpu 3: 16250 DMIPS @ 2106 Mhz
> >
> > ==> 740 : 1024
>
> I have some trouble to match the commit message to the actual patch. Commit
> message talks about cpu 1 but patch changes cpu0. Where are the values of the
> other CPUs?

Small cpu on 8173 is cpu0 & cpu1, while big cpu is cpu2 & cpu3.
Small cpu: 9502 DMIPS @ 1703 Mhz
Big cpu:   16250 DMIPS @ 2106 Mhz

9502/1703 : 16250/2106 = 740 : 1024 (scale big cpu to 1024), and this patch
changes the small cpu value to 740.



>
> Regards,
> Matthias
>
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 70b1ffcab7f0..5e046f9d48ce 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -167,7 +167,7 @@ cpu0: cpu@0 {
> >                                <&apmixedsys CLK_APMIXED_MAINPLL>;
> >                       clock-names = "cpu", "intermediate";
> >                       operating-points-v2 = <&cluster0_opp>;
> > -                     capacity-dmips-mhz = <526>;
> > +                     capacity-dmips-mhz = <740>;
> >               };
> >
> >               cpu1: cpu@1 {
> > @@ -182,7 +182,7 @@ cpu1: cpu@1 {
> >                                <&apmixedsys CLK_APMIXED_MAINPLL>;
> >                       clock-names = "cpu", "intermediate";
> >                       operating-points-v2 = <&cluster0_opp>;
> > -                     capacity-dmips-mhz = <526>;
> > +                     capacity-dmips-mhz = <740>;
> >               };
> >
> >               cpu2: cpu@100 {
> >
Matthias Brugger July 10, 2020, 1:34 p.m. UTC | #3
On 08/07/2020 20:55, Hsin-Yi Wang wrote:
> On Thu, Jul 9, 2020 at 1:01 AM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>
>>
>>
>> On 06/07/2020 10:37, Hsin-Yi Wang wrote:
>>> Re measure capacity-dmips-mhz on elm and hana:
>>>
>>> cpu 1:  9502 DMIPS @ 1703 Mhz
>>> cpu 3: 16250 DMIPS @ 2106 Mhz
>>>
>>> ==> 740 : 1024
>>
>> I have some trouble to match the commit message to the actual patch. Commit
>> message talks about cpu 1 but patch changes cpu0. Where are the values of the
>> other CPUs?
> 
> Small cpu on 8173 is cpu0 & cpu1, while big cpu is cpu2 & cpu3.
> Small cpu: 9502 DMIPS @ 1703 Mhz
> Big cpu:   16250 DMIPS @ 2106 Mhz
> 
> 9502/1703 : 16250/2106 = 740 : 1024 (scale big cpu to 1024), and this patch
> changes the small cpu value to 740.
> 
> 

applied to v5.8-next/dts64

Thanks!



> 
>>
>> Regards,
>> Matthias
>>
>>>
>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>>> ---
>>>    arch/arm64/boot/dts/mediatek/mt8173.dtsi | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 70b1ffcab7f0..5e046f9d48ce 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -167,7 +167,7 @@ cpu0: cpu@0 {
>>>                                 <&apmixedsys CLK_APMIXED_MAINPLL>;
>>>                        clock-names = "cpu", "intermediate";
>>>                        operating-points-v2 = <&cluster0_opp>;
>>> -                     capacity-dmips-mhz = <526>;
>>> +                     capacity-dmips-mhz = <740>;
>>>                };
>>>
>>>                cpu1: cpu@1 {
>>> @@ -182,7 +182,7 @@ cpu1: cpu@1 {
>>>                                 <&apmixedsys CLK_APMIXED_MAINPLL>;
>>>                        clock-names = "cpu", "intermediate";
>>>                        operating-points-v2 = <&cluster0_opp>;
>>> -                     capacity-dmips-mhz = <526>;
>>> +                     capacity-dmips-mhz = <740>;
>>>                };
>>>
>>>                cpu2: cpu@100 {
>>>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 70b1ffcab7f0..5e046f9d48ce 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -167,7 +167,7 @@  cpu0: cpu@0 {
 				 <&apmixedsys CLK_APMIXED_MAINPLL>;
 			clock-names = "cpu", "intermediate";
 			operating-points-v2 = <&cluster0_opp>;
-			capacity-dmips-mhz = <526>;
+			capacity-dmips-mhz = <740>;
 		};
 
 		cpu1: cpu@1 {
@@ -182,7 +182,7 @@  cpu1: cpu@1 {
 				 <&apmixedsys CLK_APMIXED_MAINPLL>;
 			clock-names = "cpu", "intermediate";
 			operating-points-v2 = <&cluster0_opp>;
-			capacity-dmips-mhz = <526>;
+			capacity-dmips-mhz = <740>;
 		};
 
 		cpu2: cpu@100 {