| Message ID | 20200817145738.986999-1-linux@fw-web.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "irqchip/mtk-sysirq: Convert to a platform driver" | expand |
Hi Frank, Missatge de Frank Wunderlich <linux@fw-web.de> del dia dl., 17 d’ag. 2020 a les 16:58: > > From: Frank Wunderlich <frank-w@public-files.de> > > This reverts commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 which > breaks bootup of arm/arm64 devices like bananapi-r2/mt7623 and > bananapi-r64/mt7622 > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> I already answered your BUG report, but, for the record, I think a proper fix is following his way [1] and probably will be merged soon. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=7828a3ef8646fb2e69ed45616c8453a037ca7867 Thanks, Enric > --- > drivers/irqchip/irq-mtk-sysirq.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > index 7299c5ab4d10..6ff98b87e5c0 100644 > --- a/drivers/irqchip/irq-mtk-sysirq.c > +++ b/drivers/irqchip/irq-mtk-sysirq.c > @@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct device_node *node, > kfree(chip_data); > return ret; > } > -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq) > -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) > -IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq) > +IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init); > -- > 2.25.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On 2020-08-17 15:57, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > This reverts commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 which > breaks bootup of arm/arm64 devices like bananapi-r2/mt7623 and > bananapi-r64/mt7622 > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > drivers/irqchip/irq-mtk-sysirq.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c > b/drivers/irqchip/irq-mtk-sysirq.c > index 7299c5ab4d10..6ff98b87e5c0 100644 > --- a/drivers/irqchip/irq-mtk-sysirq.c > +++ b/drivers/irqchip/irq-mtk-sysirq.c > @@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct > device_node *node, > kfree(chip_data); > return ret; > } > -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq) > -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) > -IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq) > +IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", > mtk_sysirq_of_init); There is already a fix queued for this. M.
Am 17. August 2020 17:04:32 MESZ schrieb Enric Balletbo Serra <eballetbo@gmail.com>: >I already answered your BUG report, but, for the record, I think a >proper fix is following his way [1] and probably will be merged soon. > >[1] >https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-next&id=7828a3ef8646fb2e69ed45616c8453a037ca7867 with Patch "irqchip: Fix probing deferal when using IRQCHIP_PLATFORM_DRIVER helper" i can boot my board, but i get these errors: [ 0.014234] irq: no irq domain found for interrupt-controller@10200100 ! [ 0.020981] Failed to map interrupt for /timer@10008000 [ 0.026248] Failed to initialize '/timer@10008000': -22 [ 4.314126] hw perfevents: /pmu: failed to register PMU devices! if i revert f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 these are gone regards Frank
diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 7299c5ab4d10..6ff98b87e5c0 100644 --- a/drivers/irqchip/irq-mtk-sysirq.c +++ b/drivers/irqchip/irq-mtk-sysirq.c @@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct device_node *node, kfree(chip_data); return ret; } -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq) -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) -IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq) +IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init);