diff mbox series

scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2

Message ID 20200819084340.7021-1-stanley.chu@mediatek.com (mailing list archive)
State New, archived
Headers show
Series scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2 | expand

Commit Message

Stanley Chu Aug. 19, 2020, 8:43 a.m. UTC 
From: Andy Teng <andy.teng@mediatek.com>

MediaTek UFS host starts to support 2 lanes, thus modify the
minimum lane count to 2.

This modification shall not impact old 1-lane host because
PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the
target lanes properly during power mode change. So we could relax
the limitation in ufs_dev_params.

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Andy Teng <andy.teng@mediatek.com>
Singed-off-by: Stanley Chu <stanley.chu@mediatek.com>
---
 drivers/scsi/ufs/ufs-mediatek.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Avri Altman Aug. 20, 2020, 6:03 a.m. UTC | #1 
> 
> From: Andy Teng <andy.teng@mediatek.com>
> 
> MediaTek UFS host starts to support 2 lanes, thus modify the
> minimum lane count to 2.
> 
> This modification shall not impact old 1-lane host because
> PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit
> the
> target lanes properly during power mode change. So we could relax
> the limitation in ufs_dev_params.
> 
> Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
> Signed-off-by: Andy Teng <andy.teng@mediatek.com>
> Singed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

But then again, why those constants needs to be re-negotiated every pre-change?

Thanks,
Avri
Martin K. Petersen Sept. 9, 2020, 2:17 a.m. UTC | #2 
On Wed, 19 Aug 2020 16:43:40 +0800, Stanley Chu wrote:

> MediaTek UFS host starts to support 2 lanes, thus modify the
> minimum lane count to 2.
> 
> This modification shall not impact old 1-lane host because
> PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the
> target lanes properly during power mode change. So we could relax
> the limitation in ufs_dev_params.

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: ufs: ufs-mediatek: Modify the minimum RX/TX lane count to 2
      https://git.kernel.org/mkp/scsi/c/460d74a0911c
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufs-mediatek.h b/drivers/scsi/ufs/ufs-mediatek.h
index 8ed24d5fcff9..87657376d27a 100644
--- a/drivers/scsi/ufs/ufs-mediatek.h
+++ b/drivers/scsi/ufs/ufs-mediatek.h
@@ -33,8 +33,8 @@ 
 /*
  * Vendor specific pre-defined parameters
  */
-#define UFS_MTK_LIMIT_NUM_LANES_RX  1
-#define UFS_MTK_LIMIT_NUM_LANES_TX  1
+#define UFS_MTK_LIMIT_NUM_LANES_RX  2
+#define UFS_MTK_LIMIT_NUM_LANES_TX  2
 #define UFS_MTK_LIMIT_HSGEAR_RX     UFS_HS_G3
 #define UFS_MTK_LIMIT_HSGEAR_TX     UFS_HS_G3
 #define UFS_MTK_LIMIT_PWMGEAR_RX    UFS_PWM_G4