| Message ID | 20200827072626.23331-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | maiblox: mediatek: Fix handling of platform_get_irq() error | expand |
On Thu, 27 Aug 2020 at 09:26, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver") > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 484d4438cd83..76e4dfcf5228 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -525,10 +525,8 @@ static int cmdq_probe(struct platform_device *pdev) > } > > cmdq->irq = platform_get_irq(pdev, 0); > - if (!cmdq->irq) { > - dev_err(dev, "failed to get irq\n"); > - return -EINVAL; > - } > + if (!cmdq->irq < 0) Ah, this is wrong. The irq is u32... without my patch this was so broken... Best regards, Krzysztof
diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 484d4438cd83..76e4dfcf5228 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -525,10 +525,8 @@ static int cmdq_probe(struct platform_device *pdev) } cmdq->irq = platform_get_irq(pdev, 0); - if (!cmdq->irq) { - dev_err(dev, "failed to get irq\n"); - return -EINVAL; - } + if (!cmdq->irq < 0) + return cmdq->irq; plat_data = (struct gce_plat *)of_device_get_match_data(dev); if (!plat_data) {
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)