| Message ID | 20200903063800.27288-1-dawning.pang@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cypto: mediatek - fix leaks in mtk_desc_ring_alloc | expand |
Xiaoliang Pang <dawning.pang@gmail.com> wrote: > In the init loop, if an error occurs in function 'dma_alloc_coherent', > then goto the err_cleanup section, > in the cleanup loop, after run i--, > the struct mtk_ring rising[i] will not be released, > causing a memory leak > > Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com> > --- > drivers/crypto/mediatek/mtk-platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c > index 7e3ad085b5bd..05d341e4a696 100644 > --- a/drivers/crypto/mediatek/mtk-platform.c > +++ b/drivers/crypto/mediatek/mtk-platform.c > @@ -469,7 +469,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) > return 0; > > err_cleanup: > - for (; i--; ) { > + for (; i >= 0; --i) { How about a do while loop instead? Thanks,
diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c index 7e3ad085b5bd..05d341e4a696 100644 --- a/drivers/crypto/mediatek/mtk-platform.c +++ b/drivers/crypto/mediatek/mtk-platform.c @@ -469,7 +469,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) return 0; err_cleanup: - for (; i--; ) { + for (; i >= 0; --i) { dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ, ring[i]->res_base, ring[i]->res_dma); dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ,
In the init loop, if an error occurs in function 'dma_alloc_coherent', then goto the err_cleanup section, in the cleanup loop, after run i--, the struct mtk_ring rising[i] will not be released, causing a memory leak Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com> --- drivers/crypto/mediatek/mtk-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)