| Message ID | 20200911013619.9809-1-dawning.pang@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] cypto: mediatek - fix leaks in mtk_desc_ring_alloc | expand |
On Fri, Sep 11, 2020 at 09:36:19AM +0800, Xiaoliang Pang wrote: > > diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c > index 7e3ad085b5bd..ebb3bdef0dbe 100644 > --- a/drivers/crypto/mediatek/mtk-platform.c > +++ b/drivers/crypto/mediatek/mtk-platform.c > @@ -469,13 +469,13 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) > return 0; > > err_cleanup: > - for (; i--; ) { > + do { > dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ, > ring[i]->res_base, ring[i]->res_dma); > dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ, > ring[i]->cmd_base, ring[i]->cmd_dma); > kfree(ring[i]); > - } > + }while(i--); Please add spaces before and after while. Thanks,
diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c index 7e3ad085b5bd..ebb3bdef0dbe 100644 --- a/drivers/crypto/mediatek/mtk-platform.c +++ b/drivers/crypto/mediatek/mtk-platform.c @@ -469,13 +469,13 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) return 0; err_cleanup: - for (; i--; ) { + do { dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ, ring[i]->res_base, ring[i]->res_dma); dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ, ring[i]->cmd_base, ring[i]->cmd_dma); kfree(ring[i]); - } + }while(i--); return err; }
In the init loop, if an error occurs in function 'dma_alloc_coherent', then goto the err_cleanup section, in the cleanup loop, after run i--, the struct mtk_ring rising[i] will not be released, causing a memory leak Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com> --- drivers/crypto/mediatek/mtk-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)