| Message ID | 20201102193402.GA14965@Sleakybeast (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: mt7621-dma: Prefer Using BIT Macro instead of left shifting on 1. | expand |
On Tue, Nov 03, 2020 at 01:04:02AM +0530, siddhant gupta(siddhant1223) wrote: > > Replace left shifting on 1 by a BIT macro to fix checkpatch warning. > > Signed-off-by: Siddhant Gupta <siddhantgupta416@gmail.com> > > --- > drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c > index 354536783e1c..a9e1a1b14035 100644 > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c > @@ -72,7 +72,7 @@ > #define HSDMA_GLO_TX_DMA BIT(0) > > #define HSDMA_BT_SIZE_16BYTES (0 << HSDMA_GLO_BT_SHIFT) > -#define HSDMA_BT_SIZE_32BYTES (1 << HSDMA_GLO_BT_SHIFT) > +#define HSDMA_BT_SIZE_32BYTES BIT(HSDMA_GLO_BT_SHIFT) > #define HSDMA_BT_SIZE_64BYTES (2 << HSDMA_GLO_BT_SHIFT) > #define HSDMA_BT_SIZE_128BYTES (3 << HSDMA_GLO_BT_SHIFT) In looking at the code, does this change really make sense? (hint, I don't think so...)
On Tue, 3 Nov 2020 at 01:10, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Tue, Nov 03, 2020 at 01:04:02AM +0530, siddhant gupta(siddhant1223) wrote: > > > > Replace left shifting on 1 by a BIT macro to fix checkpatch warning. > > > > Signed-off-by: Siddhant Gupta <siddhantgupta416@gmail.com> > > > > --- > > drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c > > index 354536783e1c..a9e1a1b14035 100644 > > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c > > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c > > @@ -72,7 +72,7 @@ > > #define HSDMA_GLO_TX_DMA BIT(0) > > > > #define HSDMA_BT_SIZE_16BYTES (0 << HSDMA_GLO_BT_SHIFT) > > -#define HSDMA_BT_SIZE_32BYTES (1 << HSDMA_GLO_BT_SHIFT) > > +#define HSDMA_BT_SIZE_32BYTES BIT(HSDMA_GLO_BT_SHIFT) > > #define HSDMA_BT_SIZE_64BYTES (2 << HSDMA_GLO_BT_SHIFT) > > #define HSDMA_BT_SIZE_128BYTES (3 << HSDMA_GLO_BT_SHIFT) > > In looking at the code, does this change really make sense? > > (hint, I don't think so...) Following Checkpatch, I thought it might be good to do as checkpatch said, but the code looks better and more readable without the change. This is my first patch and also a lesson that i should not fix every checkpatch warnings. I'll pick something better next time Thanks for your comment .
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c index 354536783e1c..a9e1a1b14035 100644 --- a/drivers/staging/mt7621-dma/mtk-hsdma.c +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c @@ -72,7 +72,7 @@ #define HSDMA_GLO_TX_DMA BIT(0) #define HSDMA_BT_SIZE_16BYTES (0 << HSDMA_GLO_BT_SHIFT) -#define HSDMA_BT_SIZE_32BYTES (1 << HSDMA_GLO_BT_SHIFT) +#define HSDMA_BT_SIZE_32BYTES BIT(HSDMA_GLO_BT_SHIFT) #define HSDMA_BT_SIZE_64BYTES (2 << HSDMA_GLO_BT_SHIFT) #define HSDMA_BT_SIZE_128BYTES (3 << HSDMA_GLO_BT_SHIFT)
Replace left shifting on 1 by a BIT macro to fix checkpatch warning. Signed-off-by: Siddhant Gupta <siddhantgupta416@gmail.com> --- drivers/staging/mt7621-dma/mtk-hsdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)