| Message ID | 20201116082537.3287009-2-tzungbi@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | remoteproc/mediatek: fix sparse errors | expand |
On Mon, Nov 16, 2020 at 4:26 PM Tzung-Bi Shih <tzungbi@google.com> wrote: > > Fixes the following sparse errors on sram power on and off: > > On drivers/remoteproc/mtk_scp.c:306:17: > warning: incorrect type in argument 2 (different address spaces) > expected void volatile [noderef] __iomem *addr > got void *addr > > On drivers/remoteproc/mtk_scp.c:307:9: > warning: incorrect type in argument 2 (different address spaces) > expected void volatile [noderef] __iomem *addr > got void *addr > > On drivers/remoteproc/mtk_scp.c:314:9: > warning: incorrect type in argument 2 (different address spaces) > expected void volatile [noderef] __iomem *addr > got void *addr > > On drivers/remoteproc/mtk_scp.c:316:17: > warning: incorrect type in argument 2 (different address spaces) > expected void volatile [noderef] __iomem *addr > got void *addr Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Tzung-Bi Shih <tzungbi@google.com> > --- > drivers/remoteproc/mtk_scp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 577cbd5d421e..8ed89ea1eb78 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -298,7 +298,7 @@ static int mt8183_scp_before_load(struct mtk_scp *scp) > return 0; > } > > -static void mt8192_power_on_sram(void *addr) > +static void mt8192_power_on_sram(void __iomem *addr) > { > int i; > > @@ -307,7 +307,7 @@ static void mt8192_power_on_sram(void *addr) > writel(0, addr); > } > > -static void mt8192_power_off_sram(void *addr) > +static void mt8192_power_off_sram(void __iomem *addr) > { > int i; > > -- > 2.29.2.299.gdc1121823c-goog >
On Mon, Nov 16, 2020 at 04:25:36PM +0800, Tzung-Bi Shih wrote: > Fixes the following sparse errors on sram power on and off: > > On drivers/remoteproc/mtk_scp.c:306:17: > warning: incorrect type in argument 2 (different address spaces) > expected void volatile [noderef] __iomem *addr > got void *addr > > On drivers/remoteproc/mtk_scp.c:307:9: > warning: incorrect type in argument 2 (different address spaces) > expected void volatile [noderef] __iomem *addr > got void *addr > > On drivers/remoteproc/mtk_scp.c:314:9: > warning: incorrect type in argument 2 (different address spaces) > expected void volatile [noderef] __iomem *addr > got void *addr > > On drivers/remoteproc/mtk_scp.c:316:17: > warning: incorrect type in argument 2 (different address spaces) > expected void volatile [noderef] __iomem *addr > got void *addr > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Tzung-Bi Shih <tzungbi@google.com> > --- > drivers/remoteproc/mtk_scp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 577cbd5d421e..8ed89ea1eb78 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -298,7 +298,7 @@ static int mt8183_scp_before_load(struct mtk_scp *scp) > return 0; > } > > -static void mt8192_power_on_sram(void *addr) > +static void mt8192_power_on_sram(void __iomem *addr) > { > int i; > > @@ -307,7 +307,7 @@ static void mt8192_power_on_sram(void *addr) > writel(0, addr); > } > > -static void mt8192_power_off_sram(void *addr) > +static void mt8192_power_off_sram(void __iomem *addr) Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > { > int i; > > -- > 2.29.2.299.gdc1121823c-goog >
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 577cbd5d421e..8ed89ea1eb78 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -298,7 +298,7 @@ static int mt8183_scp_before_load(struct mtk_scp *scp) return 0; } -static void mt8192_power_on_sram(void *addr) +static void mt8192_power_on_sram(void __iomem *addr) { int i; @@ -307,7 +307,7 @@ static void mt8192_power_on_sram(void *addr) writel(0, addr); } -static void mt8192_power_off_sram(void *addr) +static void mt8192_power_off_sram(void __iomem *addr) { int i;
Fixes the following sparse errors on sram power on and off: On drivers/remoteproc/mtk_scp.c:306:17: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] __iomem *addr got void *addr On drivers/remoteproc/mtk_scp.c:307:9: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] __iomem *addr got void *addr On drivers/remoteproc/mtk_scp.c:314:9: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] __iomem *addr got void *addr On drivers/remoteproc/mtk_scp.c:316:17: warning: incorrect type in argument 2 (different address spaces) expected void volatile [noderef] __iomem *addr got void *addr Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com> --- drivers/remoteproc/mtk_scp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)