[3/3] regulator: mt6323: Add OF match table

Commit Message

Matthias Brugger Jan. 9, 2021, 2:10 a.m. UTC

From: Matthias Brugger <[e-mail]>

The binding documentation mentions that a compatible is required for the
MT6323 device node. But the driver does not provide a OF match table.
This way auto-loading is broken as the MFD driver that registers the
device has a .of_compatible set which makes the platform .uevent
callback report a OF modalias, but that's not in the module.

Signed-off-by: Matthias Brugger <[e-mail]>

---

 drivers/regulator/mt6323-regulator.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

kernel test robot Jan. 9, 2021, 5:24 a.m. UTC | #1

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on regulator/for-next]
[also build test WARNING on v5.11-rc2 next-20210108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/matthias-bgg-kernel-org/regulator-mt6360-Add-OF-match-table/20210109-101451
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: mips-randconfig-r032-20210108 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bc556e5685c0f97e79fb7b3c6f15cc5062db8e36)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/ad9188be3a1fb2710a943ed2ca794c7d0e82e983
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review matthias-bgg-kernel-org/regulator-mt6360-Add-OF-match-table/20210109-101451
        git checkout ad9188be3a1fb2710a943ed2ca794c7d0e82e983
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[e-mail]>

All warnings (new ones prefixed by >>):

>> drivers/regulator/mt6323-regulator.c:409:34: warning: unused variable 'mt6323_of_match' [-Wunused-const-variable]
   static const struct of_device_id mt6323_of_match[] = {
                                    ^
   1 warning generated.


vim +/mt6323_of_match +409 drivers/regulator/mt6323-regulator.c

   408	
 > 409	static const struct of_device_id mt6323_of_match[] = {
   410		{ .compatible = "mediatek,mt6323-regulator", },
   411		{ /* sentinel */ },
   412	};
   413	MODULE_DEVICE_TABLE(of, mt6323_of_match);
   414	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[e-mail]

Patch

diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c
index ff9016170db3..b3d84e95f051 100644
--- a/drivers/regulator/mt6323-regulator.c
+++ b/drivers/regulator/mt6323-regulator.c
@@ -406,9 +406,16 @@  static const struct platform_device_id mt6323_platform_ids[] = {
 };
 MODULE_DEVICE_TABLE(platform, mt6323_platform_ids);
 
+static const struct of_device_id mt6323_of_match[] = {
+	{ .compatible = "mediatek,mt6323-regulator", },
+	{ /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, mt6323_of_match);
+
 static struct platform_driver mt6323_regulator_driver = {
 	.driver = {
 		.name = "mt6323-regulator",
+		.of_match_table = of_match_ptr(mt6323_of_match),
 	},
 	.probe = mt6323_regulator_probe,
 	.id_table = mt6323_platform_ids,