diff mbox series

arm64: dts: mt8183: Add missing power-domain for pwm0 node

Message ID 20210113215723.71966-1-enric.balletbo@collabora.com (mailing list archive)
State New
Headers show
Series arm64: dts: mt8183: Add missing power-domain for pwm0 node | expand

Commit Message

Enric Balletbo i Serra Jan. 13, 2021, 9:57 p.m. UTC
The MT8183 display PWM device will not work until the associated
power-domain is enabled. Add the power-domain reference to the node
allows the display PWM driver to operate and the backlight turn on.

Fixes: f15722c0fef0 ("arm64: dts: mt8183: Add pwm and backlight node")
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Hsin-Yi Wang Jan. 14, 2021, 7:32 a.m. UTC | #1
On Thu, Jan 14, 2021 at 5:57 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> The MT8183 display PWM device will not work until the associated
> power-domain is enabled. Add the power-domain reference to the node
> allows the display PWM driver to operate and the backlight turn on.
>
> Fixes: f15722c0fef0 ("arm64: dts: mt8183: Add pwm and backlight node")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>

> ---
>
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index bda283fa9245..8471c973dfd5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -661,6 +661,7 @@ pwm0: pwm@1100e000 {
>                         compatible = "mediatek,mt8183-disp-pwm";
>                         reg = <0 0x1100e000 0 0x1000>;
>                         interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
> +                       power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
>                         #pwm-cells = <2>;
>                         clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
>                                         <&infracfg CLK_INFRA_DISP_PWM>;
> --
> 2.29.2
>
Matthias Brugger Jan. 28, 2021, 5:09 p.m. UTC | #2
On 13/01/2021 22:57, Enric Balletbo i Serra wrote:
> The MT8183 display PWM device will not work until the associated
> power-domain is enabled. Add the power-domain reference to the node
> allows the display PWM driver to operate and the backlight turn on.
> 
> Fixes: f15722c0fef0 ("arm64: dts: mt8183: Add pwm and backlight node")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---

applied to v5.11-next/dts64

Thanks!

> 
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index bda283fa9245..8471c973dfd5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -661,6 +661,7 @@ pwm0: pwm@1100e000 {
>  			compatible = "mediatek,mt8183-disp-pwm";
>  			reg = <0 0x1100e000 0 0x1000>;
>  			interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
> +			power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
>  			#pwm-cells = <2>;
>  			clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
>  					<&infracfg CLK_INFRA_DISP_PWM>;
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index bda283fa9245..8471c973dfd5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -661,6 +661,7 @@  pwm0: pwm@1100e000 {
 			compatible = "mediatek,mt8183-disp-pwm";
 			reg = <0 0x1100e000 0 0x1000>;
 			interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_LOW>;
+			power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
 			#pwm-cells = <2>;
 			clocks = <&topckgen CLK_TOP_MUX_DISP_PWM>,
 					<&infracfg CLK_INFRA_DISP_PWM>;