| Message ID | 20210121062429.26504-3-yong.wu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] memory: mtk-smi: Use platform_register_drivers | expand |
On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > The config MTK_SMI always depends on MTK_IOMMU which is built-in > currently. Thus we don't have module_exit before. This patch adds > module_exit and module_license. It is a preparing patch for supporting > MTK_SMI could been built as a module. > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > --- > drivers/memory/mtk-smi.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index e2aebd2bfa8e..aa2a25abf04f 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > } > module_init(mtk_smi_init); > + > +static void __exit mtk_smi_exit(void) > +{ > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > +} > +module_exit(mtk_smi_exit); > + > +MODULE_DESCRIPTION("MediaTek SMI driver"); > +MODULE_ALIAS("platform:MediaTek-SMI"); Drivers do not use capital letters, so I have doubts whether this alias is correct. Adding all these should be squashed with changing Kconfig into tristate. It does not have sense on its own. Best regards, Krzysztof
On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote: > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > > The config MTK_SMI always depends on MTK_IOMMU which is built-in > > currently. Thus we don't have module_exit before. This patch adds > > module_exit and module_license. It is a preparing patch for supporting > > MTK_SMI could been built as a module. > > > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > --- > > drivers/memory/mtk-smi.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > index e2aebd2bfa8e..aa2a25abf04f 100644 > > --- a/drivers/memory/mtk-smi.c > > +++ b/drivers/memory/mtk-smi.c > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > } > > module_init(mtk_smi_init); > > + > > +static void __exit mtk_smi_exit(void) > > +{ > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > +} > > +module_exit(mtk_smi_exit); > > + > > +MODULE_DESCRIPTION("MediaTek SMI driver"); > > +MODULE_ALIAS("platform:MediaTek-SMI"); > > Drivers do not use capital letters, so I have doubts whether this alias > is correct. I didn't care the upper/lower-case. I will change to lower case in next time. MODULE_ALIAS("platform:MediaTek-smi") > > Adding all these should be squashed with changing Kconfig into tristate. > It does not have sense on its own. Thanks very much for review. Only confirm: Squash whole this patch or only squash the MODULE_x into the next patch? > > Best regards, > Krzysztof
On Mon, Jan 25, 2021 at 02:49:41PM +0800, Yong Wu wrote: > On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote: > > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > > > The config MTK_SMI always depends on MTK_IOMMU which is built-in > > > currently. Thus we don't have module_exit before. This patch adds > > > module_exit and module_license. It is a preparing patch for supporting > > > MTK_SMI could been built as a module. > > > > > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > > --- > > > drivers/memory/mtk-smi.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > > index e2aebd2bfa8e..aa2a25abf04f 100644 > > > --- a/drivers/memory/mtk-smi.c > > > +++ b/drivers/memory/mtk-smi.c > > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > } > > > module_init(mtk_smi_init); > > > + > > > +static void __exit mtk_smi_exit(void) > > > +{ > > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > +} > > > +module_exit(mtk_smi_exit); > > > + > > > +MODULE_DESCRIPTION("MediaTek SMI driver"); > > > +MODULE_ALIAS("platform:MediaTek-SMI"); > > > > Drivers do not use capital letters, so I have doubts whether this alias > > is correct. > > I didn't care the upper/lower-case. I will change to lower case in next > time. Then why do you need the alias? The name does not match driver name, so what's the purpose of this alias/ > > MODULE_ALIAS("platform:MediaTek-smi") > > > > > Adding all these should be squashed with changing Kconfig into tristate. > > It does not have sense on its own. > > Thanks very much for review. > > Only confirm: Squash whole this patch or only squash the MODULE_x into > the next patch? This entire patch 2/3 should be with 3/3. Best regards, Krzysztof
On Mon, 2021-01-25 at 09:40 +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 25, 2021 at 02:49:41PM +0800, Yong Wu wrote: > > On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote: > > > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > > > > The config MTK_SMI always depends on MTK_IOMMU which is built-in > > > > currently. Thus we don't have module_exit before. This patch adds > > > > module_exit and module_license. It is a preparing patch for supporting > > > > MTK_SMI could been built as a module. > > > > > > > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > > > --- > > > > drivers/memory/mtk-smi.c | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > > > index e2aebd2bfa8e..aa2a25abf04f 100644 > > > > --- a/drivers/memory/mtk-smi.c > > > > +++ b/drivers/memory/mtk-smi.c > > > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > > > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > > } > > > > module_init(mtk_smi_init); > > > > + > > > > +static void __exit mtk_smi_exit(void) > > > > +{ > > > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > > +} > > > > +module_exit(mtk_smi_exit); > > > > + > > > > +MODULE_DESCRIPTION("MediaTek SMI driver"); > > > > +MODULE_ALIAS("platform:MediaTek-SMI"); > > > > > > Drivers do not use capital letters, so I have doubts whether this alias > > > is correct. > > > > I didn't care the upper/lower-case. I will change to lower case in next > > time. > > Then why do you need the alias? The name does not match driver name, so > what's the purpose of this alias/ I think it is not so necessary for us. I will delete this line in next version. Only curious what's alias is fit in our case? normally it should be the file name: mtk-smi? > > > > > MODULE_ALIAS("platform:MediaTek-smi") > > > > > > > > Adding all these should be squashed with changing Kconfig into tristate. > > > It does not have sense on its own. > > > > Thanks very much for review. > > > > Only confirm: Squash whole this patch or only squash the MODULE_x into > > the next patch? > > This entire patch 2/3 should be with 3/3. Thanks for the confirm. > > Best regards, > Krzysztof
On Mon, Jan 25, 2021 at 05:28:05PM +0800, Yong Wu wrote: > On Mon, 2021-01-25 at 09:40 +0100, Krzysztof Kozlowski wrote: > > On Mon, Jan 25, 2021 at 02:49:41PM +0800, Yong Wu wrote: > > > On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote: > > > > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > > > > > The config MTK_SMI always depends on MTK_IOMMU which is built-in > > > > > currently. Thus we don't have module_exit before. This patch adds > > > > > module_exit and module_license. It is a preparing patch for supporting > > > > > MTK_SMI could been built as a module. > > > > > > > > > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > > > > --- > > > > > drivers/memory/mtk-smi.c | 10 ++++++++++ > > > > > 1 file changed, 10 insertions(+) > > > > > > > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > > > > index e2aebd2bfa8e..aa2a25abf04f 100644 > > > > > --- a/drivers/memory/mtk-smi.c > > > > > +++ b/drivers/memory/mtk-smi.c > > > > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > > > > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > > > } > > > > > module_init(mtk_smi_init); > > > > > + > > > > > +static void __exit mtk_smi_exit(void) > > > > > +{ > > > > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > > > +} > > > > > +module_exit(mtk_smi_exit); > > > > > + > > > > > +MODULE_DESCRIPTION("MediaTek SMI driver"); > > > > > +MODULE_ALIAS("platform:MediaTek-SMI"); > > > > > > > > Drivers do not use capital letters, so I have doubts whether this alias > > > > is correct. > > > > > > I didn't care the upper/lower-case. I will change to lower case in next > > > time. > > > > Then why do you need the alias? The name does not match driver name, so > > what's the purpose of this alias/ > > I think it is not so necessary for us. I will delete this line in next > version. > > Only curious what's alias is fit in our case? normally it should be the > file name: mtk-smi? If autoloading of your module works, then remove it. The alias is necessary for some cases when a device table is missing (e.g. platform driver is matched via devicetree but not having the platform_device_id table) or matching is done via different method (e.g. driver is matched from MFD via devicetree compatible even though there is a platform_device_id table). Best regards, Krzysztof
On Mon, 2021-01-25 at 11:40 +0100, Krzysztof Kozlowski wrote: > On Mon, Jan 25, 2021 at 05:28:05PM +0800, Yong Wu wrote: > > On Mon, 2021-01-25 at 09:40 +0100, Krzysztof Kozlowski wrote: > > > On Mon, Jan 25, 2021 at 02:49:41PM +0800, Yong Wu wrote: > > > > On Fri, 2021-01-22 at 22:34 +0100, Krzysztof Kozlowski wrote: > > > > > On Thu, Jan 21, 2021 at 02:24:28PM +0800, Yong Wu wrote: > > > > > > The config MTK_SMI always depends on MTK_IOMMU which is built-in > > > > > > currently. Thus we don't have module_exit before. This patch adds > > > > > > module_exit and module_license. It is a preparing patch for supporting > > > > > > MTK_SMI could been built as a module. > > > > > > > > > > > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > > > > > --- > > > > > > drivers/memory/mtk-smi.c | 10 ++++++++++ > > > > > > 1 file changed, 10 insertions(+) > > > > > > > > > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > > > > > index e2aebd2bfa8e..aa2a25abf04f 100644 > > > > > > --- a/drivers/memory/mtk-smi.c > > > > > > +++ b/drivers/memory/mtk-smi.c > > > > > > @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) > > > > > > return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > > > > } > > > > > > module_init(mtk_smi_init); > > > > > > + > > > > > > +static void __exit mtk_smi_exit(void) > > > > > > +{ > > > > > > + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); > > > > > > +} > > > > > > +module_exit(mtk_smi_exit); > > > > > > + > > > > > > +MODULE_DESCRIPTION("MediaTek SMI driver"); > > > > > > +MODULE_ALIAS("platform:MediaTek-SMI"); > > > > > > > > > > Drivers do not use capital letters, so I have doubts whether this alias > > > > > is correct. > > > > > > > > I didn't care the upper/lower-case. I will change to lower case in next > > > > time. > > > > > > Then why do you need the alias? The name does not match driver name, so > > > what's the purpose of this alias/ > > > > I think it is not so necessary for us. I will delete this line in next > > version. > > > > Only curious what's alias is fit in our case? normally it should be the > > file name: mtk-smi? > > If autoloading of your module works, then remove it. The alias is > necessary for some cases when a device table is missing (e.g. platform > driver is matched via devicetree but not having the platform_device_id > table) or matching is done via different method (e.g. driver is matched > from MFD via devicetree compatible even though there is a > platform_device_id table). Thanks for explaination so detailly. v2 is sent just now. > > Best regards, > Krzysztof
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index e2aebd2bfa8e..aa2a25abf04f 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -597,3 +597,13 @@ static int __init mtk_smi_init(void) return platform_register_drivers(smidrivers, ARRAY_SIZE(smidrivers)); } module_init(mtk_smi_init); + +static void __exit mtk_smi_exit(void) +{ + platform_unregister_drivers(smidrivers, ARRAY_SIZE(smidrivers)); +} +module_exit(mtk_smi_exit); + +MODULE_DESCRIPTION("MediaTek SMI driver"); +MODULE_ALIAS("platform:MediaTek-SMI"); +MODULE_LICENSE("GPL v2");
The config MTK_SMI always depends on MTK_IOMMU which is built-in currently. Thus we don't have module_exit before. This patch adds module_exit and module_license. It is a preparing patch for supporting MTK_SMI could been built as a module. Signed-off-by: Yong Wu <yong.wu@mediatek.com> --- drivers/memory/mtk-smi.c | 10 ++++++++++ 1 file changed, 10 insertions(+)