| Message ID | 20210204150001.102672-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next,V2] iommu/mediatek: Fix unsigned domid comparison with less than zero | expand |
On Thu, Feb 04, 2021 at 03:00:01PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently the check for domid < 0 is always false because domid > is unsigned. Fix this by casting domid to an int before making > the comparison. > > Addresses-Coverity: ("Unsigned comparison against 0") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > > V2: cast domid rather than making it an int. Replace L with : in > the commit message. > > --- > drivers/iommu/mtk_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 0ad14a7604b1..1f262621ef19 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -645,7 +645,7 @@ static void mtk_iommu_get_resv_regions(struct device *dev, > struct iommu_resv_region *region; > int prot = IOMMU_WRITE | IOMMU_READ; > > - if (domid < 0) > + if ((int)domid < 0) > return; > curdom = data->plat_data->iova_region + domid; > for (i = 0; i < data->plat_data->iova_region_nr; i++) { Thanks, Colin. Acked-by: Will Deacon <will@kernel.org> Will
On Thu, Feb 04, 2021 at 03:00:01PM +0000, Colin King wrote: > drivers/iommu/mtk_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 0ad14a7604b1..1f262621ef19 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -645,7 +645,7 @@ static void mtk_iommu_get_resv_regions(struct device *dev, struct iommu_resv_region *region; int prot = IOMMU_WRITE | IOMMU_READ; - if (domid < 0) + if ((int)domid < 0) return; curdom = data->plat_data->iova_region + domid; for (i = 0; i < data->plat_data->iova_region_nr; i++) {