| Message ID | 20210210075656.1096251-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] soc: mediatek: Make symbol 'mtk_mutex_driver' static | expand |
Hi, Yongjun: Wei Yongjun <weiyongjun1@huawei.com> 於 2021年2月10日 週三 下午3:49寫道： > > The sparse tool complains as follows: > > drivers/soc/mediatek/mtk-mutex.c:464:24: warning: > symbol 'mtk_mutex_driver' was not declared. Should it be static? > > This symbol is not used outside of mtk-mutex.c, so this > commit marks it static. Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/soc/mediatek/mtk-mutex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c > index f531b119da7a..3a315a62e783 100644 > --- a/drivers/soc/mediatek/mtk-mutex.c > +++ b/drivers/soc/mediatek/mtk-mutex.c > @@ -461,7 +461,7 @@ static const struct of_device_id mutex_driver_dt_match[] = { > }; > MODULE_DEVICE_TABLE(of, mutex_driver_dt_match); > > -struct platform_driver mtk_mutex_driver = { > +static struct platform_driver mtk_mutex_driver = { > .probe = mtk_mutex_probe, > .remove = mtk_mutex_remove, > .driver = { > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On 10/02/2021 08:56, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/soc/mediatek/mtk-mutex.c:464:24: warning: > symbol 'mtk_mutex_driver' was not declared. Should it be static? > > This symbol is not used outside of mtk-mutex.c, so this > commit marks it static. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied to v5.12-next/soc Thanks! > --- > drivers/soc/mediatek/mtk-mutex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c > index f531b119da7a..3a315a62e783 100644 > --- a/drivers/soc/mediatek/mtk-mutex.c > +++ b/drivers/soc/mediatek/mtk-mutex.c > @@ -461,7 +461,7 @@ static const struct of_device_id mutex_driver_dt_match[] = { > }; > MODULE_DEVICE_TABLE(of, mutex_driver_dt_match); > > -struct platform_driver mtk_mutex_driver = { > +static struct platform_driver mtk_mutex_driver = { > .probe = mtk_mutex_probe, > .remove = mtk_mutex_remove, > .driver = { >
diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c index f531b119da7a..3a315a62e783 100644 --- a/drivers/soc/mediatek/mtk-mutex.c +++ b/drivers/soc/mediatek/mtk-mutex.c @@ -461,7 +461,7 @@ static const struct of_device_id mutex_driver_dt_match[] = { }; MODULE_DEVICE_TABLE(of, mutex_driver_dt_match); -struct platform_driver mtk_mutex_driver = { +static struct platform_driver mtk_mutex_driver = { .probe = mtk_mutex_probe, .remove = mtk_mutex_remove, .driver = {
The sparse tool complains as follows: drivers/soc/mediatek/mtk-mutex.c:464:24: warning: symbol 'mtk_mutex_driver' was not declared. Should it be static? This symbol is not used outside of mtk-mutex.c, so this commit marks it static. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/soc/mediatek/mtk-mutex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)