From patchwork Sat Apr 10 09:11:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?WW9uZyBXdSAo5ZC05YuHKQ==?= X-Patchwork-Id: 12195489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F6AC433B4 for ; Sat, 10 Apr 2021 09:14:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 410F860233 for ; Sat, 10 Apr 2021 09:14:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 410F860233 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rCY7F71HTYs5qPLL+92lxyTnUwRHQAiiOum2fajgdIA=; b=mq1lhxYyDzAnKUNXlXWzVrSFo HNVb+u2jn/He+bIhCR7F0/kTuDWMTD3zg83fD8Uv+AqZk28RaZxpWLVCje2otI0xgOdqy6HsUCka2 4xPUxLzft4JWSv4P9yJbiFixeX20FnHzEyA3Zlf4jxTR6Jk72qWdvdFEqRvIU112qzDAQhpGNoiXG p52NLNriKLNcw9Jz16s3dVo3i7Hd490DMSlH5LHuUFgHsdhBdyVkDLfo1IFwZ5c4zqdbpXRoWyIho nTagP/spsMx2VJXGHZKdmeCnXDMvAsmEm+PvUiN64Zg6eH7hPbTcgeU1FxiCjC1/GzOHp1AEbmtiZ 6vZGNCfcQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lV9gq-002VE5-Su; Sat, 10 Apr 2021 09:14:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV9gG-002Ux6-3Y; Sat, 10 Apr 2021 09:13:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=7wLbHJuGWXb8tMn1slNJ51TrOaLsIDOoOeVSKzVxLz8=; b=x70Nut/bs+Zkz5aubJV/dsXGN0 jGFFPlHBmBVbPytHJc2+NLItlirYlamOUA3LeWAyhHoQtWBZyXiL2r8ZzaXWfu7gNgB6Q2vS8JsJA 1kemGIKsVEKOXwrUM+jPYaF0UMJFcq1Msnhubyy6c4fmrSpOl7GlZGZ3BOEUoRLoD1/RajGttyWgb gP4XVqp9adFpbyoESNKFS2Q5Y7201WUDlpCfbke6pp7cW6Mcb0AecdZfhZFwVr0MbcvpaRx+xHUcR qZB9LIiUcnKYm1ALorDQ7XPrS3Rw1VgviyMvxO+pzJOjXkxJfR+mzNNMPjrQy1+axUBwzIWaCheh3 QUIdL1/A==; Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lV9gD-0050L9-O5; Sat, 10 Apr 2021 09:13:26 +0000 X-UUID: 7b6ef30c68db4deda59427f836633095-20210410 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=7wLbHJuGWXb8tMn1slNJ51TrOaLsIDOoOeVSKzVxLz8=; b=qdm2dbFMkvFoUYnHR+QAfqjoG1PU3/VEnXsAWaCmCo6SdWyQzTPwg3vqAWr+IMEPvxMZHwHNRdfl8H8HfLKiUxq5qL0Dbofx8E4ZwwIJHMYFmaD3//8aQI7bKRecQdBebX54NUqz0yamIEvauo27h9k4L21ePFb0v3cFUOE4neI=; X-UUID: 7b6ef30c68db4deda59427f836633095-20210410 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1353813916; Sat, 10 Apr 2021 02:13:24 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 10 Apr 2021 02:13:23 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 10 Apr 2021 17:13:21 +0800 Received: from localhost.localdomain (10.17.3.153) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 10 Apr 2021 17:13:20 +0800 From: Yong Wu To: Matthias Brugger , Joerg Roedel , Rob Herring , Krzysztof Kozlowski CC: Evan Green , Robin Murphy , Tomasz Figa , Will Deacon , , , , , , , , , Nicolas Boichat , Matthias Kaehlcke , , , , , , Subject: [PATCH v5 09/16] drm/mediatek: Use pm_runtime_resume_and_get for PM get_sync Date: Sat, 10 Apr 2021 17:11:21 +0800 Message-ID: <20210410091128.31823-10-yong.wu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20210410091128.31823-1-yong.wu@mediatek.com> References: <20210410091128.31823-1-yong.wu@mediatek.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210410_021325_805281_6184E4F7 X-CRM114-Status: GOOD ( 12.89 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org pm_runtime_get_sync will increment pm usage counter even it failed. This patch use pm_runtime_resume_and_get instead of pm_runtime_get to keep usage counter balanced. Signed-off-by: Yong Wu Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 8b0de90156c6..69d23ce56d2c 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c @@ -259,7 +259,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc) drm_connector_list_iter_end(&conn_iter); } - ret = pm_runtime_get_sync(crtc->dev->dev); + ret = pm_runtime_resume_and_get(crtc->dev->dev); if (ret < 0) { DRM_ERROR("Failed to enable power domain: %d\n", ret); return ret;