diff mbox series

[3/3] arm64: dts: mt8183-kukui: fix dtbs_check warnings

Message ID 20210414144643.17435-3-matthias.bgg@kernel.org (mailing list archive)
State New
Headers show
Series [1/3] arm64: dts: mt8183-pumpkin: fix dtbs_check warning | expand

Commit Message

Matthias Brugger April 14, 2021, 2:46 p.m. UTC
From: Matthias Brugger <matthias.bgg@gmail.com>

The dsi children don't have any reg property, so we don't need address and
size cells. This makes dtbs_check happy.

CC: Hsin-Yi Wang <hsinyi@chromium.org>
CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
CC: Nicolas Boichat <drinkcat@chromium.org>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

---

 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Nicolas Boichat April 15, 2021, 12:29 a.m. UTC | #1
On Wed, Apr 14, 2021 at 10:46 PM <matthias.bgg@kernel.org> wrote:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> The dsi children don't have any reg property,

Confused, see below.

> so we don't need address and
> size cells. This makes dtbs_check happy.
>
> CC: Hsin-Yi Wang <hsinyi@chromium.org>
> CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> CC: Nicolas Boichat <drinkcat@chromium.org>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>
> ---
>
>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..f4dca6a33168 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -251,8 +251,7 @@ &cpu7 {
>
>  &dsi0 {
>         status = "okay";
> -       #address-cells = <1>;
> -       #size-cells = <0>;
> +
>         panel: panel@0 {
>                 /* compatible will be set in board dts */
>                 reg = <0>;

^^ isn't that... a reg property?

> --
> 2.30.2
>
Matthias Brugger April 15, 2021, 7:47 a.m. UTC | #2
Hi Nicolas,

On 15/04/2021 02:29, Nicolas Boichat wrote:
> On Wed, Apr 14, 2021 at 10:46 PM <matthias.bgg@kernel.org> wrote:
>>
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> The dsi children don't have any reg property,
> 
> Confused, see below.
> 
>> so we don't need address and
>> size cells. This makes dtbs_check happy.
>>
>> CC: Hsin-Yi Wang <hsinyi@chromium.org>
>> CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> CC: Nicolas Boichat <drinkcat@chromium.org>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> ---
>>
>>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> index ff56bcfa3370..f4dca6a33168 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> @@ -251,8 +251,7 @@ &cpu7 {
>>
>>  &dsi0 {
>>         status = "okay";
>> -       #address-cells = <1>;
>> -       #size-cells = <0>;
>> +
>>         panel: panel@0 {
>>                 /* compatible will be set in board dts */
>>                 reg = <0>;
> 
> ^^ isn't that... a reg property?
> 

Yes, that's my fault. I'm not quite sure why we would need this reg property. In
any case also we have it present "dtbs_check W=1" throws the following warning:
mediatek/mt8183.dtsi:1234.22-1246.5: Warning (avoid_unnecessary_addr_size):
/soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or
child "reg" property


Can you have a look at that?

Regards,
Matthias

>> --
>> 2.30.2
>>
Enric Balletbo i Serra April 15, 2021, 8:37 a.m. UTC | #3
Hi Matthias,

On 15/4/21 9:47, Matthias Brugger wrote:
> Hi Nicolas,
> 
> On 15/04/2021 02:29, Nicolas Boichat wrote:
>> On Wed, Apr 14, 2021 at 10:46 PM <matthias.bgg@kernel.org> wrote:
>>>
>>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>>
>>> The dsi children don't have any reg property,
>>
>> Confused, see below.
>>
>>> so we don't need address and
>>> size cells. This makes dtbs_check happy.
>>>
>>> CC: Hsin-Yi Wang <hsinyi@chromium.org>
>>> CC: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>> CC: Nicolas Boichat <drinkcat@chromium.org>
>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>
>>> ---
>>>
>>>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> index ff56bcfa3370..f4dca6a33168 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> @@ -251,8 +251,7 @@ &cpu7 {
>>>
>>>  &dsi0 {
>>>         status = "okay";
>>> -       #address-cells = <1>;
>>> -       #size-cells = <0>;
>>> +
>>>         panel: panel@0 {
>>>                 /* compatible will be set in board dts */
>>>                 reg = <0>;
>>
>> ^^ isn't that... a reg property?
>>
> 
> Yes, that's my fault. I'm not quite sure why we would need this reg property. In
> any case also we have it present "dtbs_check W=1" throws the following warning:
> mediatek/mt8183.dtsi:1234.22-1246.5: Warning (avoid_unnecessary_addr_size):
> /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or
> child "reg" property
> 
> 
> Can you have a look at that?
> 

I think it is needed reg. See at
Documentation/devicetree/bindings/display/dsi-controller.yaml

Regards,
Enric

> Regards,
> Matthias
> 
>>> --
>>> 2.30.2
>>>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ff56bcfa3370..f4dca6a33168 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -251,8 +251,7 @@  &cpu7 {
 
 &dsi0 {
 	status = "okay";
-	#address-cells = <1>;
-	#size-cells = <0>;
+
 	panel: panel@0 {
 		/* compatible will be set in board dts */
 		reg = <0>;