Message ID | 20210416034712.7891-1-zhuguangqing83@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | regulator: mt6360: Fix missing IRQF_ONESHOT as only threaded handler | expand |
On Fri, 16 Apr 2021 at 06:30, <zhuguangqing83@gmail.com> wrote: > > From: Guangqing Zhu <zhuguangqing83@gmail.com> > > Coccinelle noticed: > drivers/regulator/mt6360-regulator.c:386:8-33: ERROR: Threaded IRQ with no > primary handler requested without IRQF_ONESHOT This should be tested. There are several patches like this all over the tree so it looks like "let's fix everything from Coccinelle" because you ignored at least in some of the cases that the handler is not the primary one. I am not saying that the change is bad, but rather it looks automated. Best regards, Krzysztof
diff --git a/drivers/regulator/mt6360-regulator.c b/drivers/regulator/mt6360-regulator.c index 4d34be94d166..34c354721ef0 100644 --- a/drivers/regulator/mt6360-regulator.c +++ b/drivers/regulator/mt6360-regulator.c @@ -383,8 +383,8 @@ static int mt6360_regulator_irq_register(struct platform_device *pdev, if (irq < 0) return irq; - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler, 0, - irq_desc->name, rdev); + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, irq_desc->handler, + IRQF_ONESHOT, irq_desc->name, rdev); if (ret) { dev_err(&pdev->dev, "Fail to request %s irq\n", irq_desc->name); return ret;