diff mbox series

dt-bindings: net: mediatek: support MT7621 SoC

Message ID 20210419034253.21322-1-ilya.lipnitskiy@gmail.com (mailing list archive)
State New
Headers show
Series dt-bindings: net: mediatek: support MT7621 SoC | expand

Commit Message

Ilya Lipnitskiy April 19, 2021, 3:42 a.m. UTC
Add missing binding documentation for SoC support that has been in place
since v5.1

Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware")
Cc: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
---
 Documentation/devicetree/bindings/net/mediatek-net.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjørn Mork April 19, 2021, 6:24 a.m. UTC | #1
Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> writes:

> Add missing binding documentation for SoC support that has been in place
> since v5.1
>
> Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware")
> Cc: Bjørn Mork <bjorn@mork.no>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/mediatek-net.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> index 72d03e07cf7c..950ef6af20b1 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> @@ -10,6 +10,7 @@ Required properties:
>  - compatible: Should be
>  		"mediatek,mt2701-eth": for MT2701 SoC
>  		"mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC
> +		"mediatek,mt7621-eth": for MT7621 SoC
>  		"mediatek,mt7622-eth": for MT7622 SoC
>  		"mediatek,mt7629-eth": for MT7629 SoC
>  		"ralink,rt5350-eth": for Ralink Rt5350F and MT7628/88 SoC


Thanks for taking care of this!

Note, however, that this compatible value is defined in
Documentation/devicetree/bindings/net/ralink,rt2880-net.txt

I believe that file should go away. These two files are both documenting
the same compatible property AFAICS.


Bjørn
Ilya Lipnitskiy April 19, 2021, 3:12 p.m. UTC | #2
On Sun, Apr 18, 2021 at 11:24 PM Bjørn Mork <bjorn@mork.no> wrote:
>
> Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> writes:
>
> > Add missing binding documentation for SoC support that has been in place
> > since v5.1
> >
> > Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware")
> > Cc: Bjørn Mork <bjorn@mork.no>
> > Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/net/mediatek-net.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> > index 72d03e07cf7c..950ef6af20b1 100644
> > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> > @@ -10,6 +10,7 @@ Required properties:
> >  - compatible: Should be
> >               "mediatek,mt2701-eth": for MT2701 SoC
> >               "mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC
> > +             "mediatek,mt7621-eth": for MT7621 SoC
> >               "mediatek,mt7622-eth": for MT7622 SoC
> >               "mediatek,mt7629-eth": for MT7629 SoC
> >               "ralink,rt5350-eth": for Ralink Rt5350F and MT7628/88 SoC
>
>
> Thanks for taking care of this!
>
> Note, however, that this compatible value is defined in
> Documentation/devicetree/bindings/net/ralink,rt2880-net.txt
Good point. I don't think there is a driver in-tree for that binding.
It looks like commit 663148e48a66 ("Documentation: DT: net: add docs
for ralink/mediatek SoC ethernet binding") should just be reverted and
the three documents (mediatek,mt7620-gsw.txt; ralink,rt2880-net.txt;
ralink,rt3050-esw.txt) removed. Any objections?

Ilya
Ilya Lipnitskiy April 20, 2021, 2:44 a.m. UTC | #3
On Sun, Apr 18, 2021 at 11:24 PM Bjørn Mork <bjorn@mork.no> wrote:
>
> Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> writes:
>
> > Add missing binding documentation for SoC support that has been in place
> > since v5.1
> >
> > Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware")
> > Cc: Bjørn Mork <bjorn@mork.no>
> > Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/net/mediatek-net.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> > index 72d03e07cf7c..950ef6af20b1 100644
> > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> > @@ -10,6 +10,7 @@ Required properties:
> >  - compatible: Should be
> >               "mediatek,mt2701-eth": for MT2701 SoC
> >               "mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC
> > +             "mediatek,mt7621-eth": for MT7621 SoC
> >               "mediatek,mt7622-eth": for MT7622 SoC
> >               "mediatek,mt7629-eth": for MT7629 SoC
> >               "ralink,rt5350-eth": for Ralink Rt5350F and MT7628/88 SoC
>
>
> Thanks for taking care of this!
>
> Note, however, that this compatible value is defined in
> Documentation/devicetree/bindings/net/ralink,rt2880-net.txt
>
> I believe that file should go away. These two files are both documenting
> the same compatible property AFAICS.
Removed along with two others in
https://lore.kernel.org/lkml/20210420024222.101615-1-ilya.lipnitskiy@gmail.com/T/#u

Ilya
Rob Herring April 21, 2021, 9:19 p.m. UTC | #4
On Sun, 18 Apr 2021 20:42:53 -0700, Ilya Lipnitskiy wrote:
> Add missing binding documentation for SoC support that has been in place
> since v5.1
> 
> Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware")
> Cc: Bjørn Mork <bjorn@mork.no>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/mediatek-net.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
index 72d03e07cf7c..950ef6af20b1 100644
--- a/Documentation/devicetree/bindings/net/mediatek-net.txt
+++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
@@ -10,6 +10,7 @@  Required properties:
 - compatible: Should be
 		"mediatek,mt2701-eth": for MT2701 SoC
 		"mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC
+		"mediatek,mt7621-eth": for MT7621 SoC
 		"mediatek,mt7622-eth": for MT7622 SoC
 		"mediatek,mt7629-eth": for MT7629 SoC
 		"ralink,rt5350-eth": for Ralink Rt5350F and MT7628/88 SoC