diff mbox series

[v3,2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc

Message ID 20210507021127.54717-2-chunfeng.yun@mediatek.com (mailing list archive)
State New
Headers show
Series [v3,1/4] usb: xhci-mtk: use bitfield instead of bool | expand

Commit Message

Chunfeng Yun May 7, 2021, 2:11 a.m. UTC
Due to @has_ippc's default value is 0, no need set it again if fail
to get ippc base address

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v3: new patch suggested by Greg
    fix typo suggested by Sergei
---
 drivers/usb/host/xhci-mtk.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ikjoon Jang June 10, 2021, 3:32 a.m. UTC | #1
On Fri, May 7, 2021 at 10:11 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> Due to @has_ippc's default value is 0, no need set it again if fail
> to get ippc base address
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Reviewed-and-Tested-by: Ikjoon Jang <ikjn@chromium.org>

> ---
> v3: new patch suggested by Greg
>     fix typo suggested by Sergei
> ---
>  drivers/usb/host/xhci-mtk.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index b2058b3bc834..2548976bcf05 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev)
>                         goto put_usb2_hcd;
>                 }
>                 mtk->has_ippc = true;
> -       } else {
> -               mtk->has_ippc = false;
>         }
>
>         device_init_wakeup(dev, true);
> --
> 2.18.0
>
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index b2058b3bc834..2548976bcf05 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -495,8 +495,6 @@  static int xhci_mtk_probe(struct platform_device *pdev)
 			goto put_usb2_hcd;
 		}
 		mtk->has_ippc = true;
-	} else {
-		mtk->has_ippc = false;
 	}
 
 	device_init_wakeup(dev, true);