From patchwork Tue May 11 11:35:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhen Lei X-Patchwork-Id: 12250889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A045C433ED for ; Tue, 11 May 2021 13:10:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 157E76191A for ; Tue, 11 May 2021 13:10:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 157E76191A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=SqgPTh4vEkTgIjhclsyAVIyWehIjFSzQoIbBvBY4XkI=; b=RAmd52Ij5Crf2JzBRPAg612nDN fkw9piE6CjsebH3049zOqnrJkpmIHhmozBErNpuWJbxtlMmsNW4xGFhcgwEF63Y+IQfVekGCiotkG RCPb0zfz6hA5U6jme9YbYpoPNjoi78wDmWVSVPR0vNMCF25Pa3ShcTGmQdxvlCpVUmeESZcAc+Euy ZEeNh8GpFbj/EePWaY23KY674/2nMxJz3wdp3K1au5+8wKvsxmVXyrmLCbl0Sg6yEYG4JwqwQSeB+ L94QzK6xNUu3EjSR4JBWz8NpC/IsiQkx4jYQ+e9pbJYVSbHAuXd1yvB4Y21blhOsJZx8r0Dmr/opi ZQXRwgPQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgS9J-00HalH-Vi; Tue, 11 May 2021 13:10:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQgT-00H9q3-40; Tue, 11 May 2021 11:36:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=XujQCoHmV5Zhfq7FvhSAmrLTxxZOS2Lo1ijM3m4New8=; b=w3xKvW2bU7ZQweHVBOjJ+wcxXq vz2girXjzWMKJpmc4hF18SE3wrCKDxEaZqbJh+9k/pLxWx2yaKCu0A33oSkky9q3UtTcj1ftkqJNE Stt4C0ePn6VarKGz1i/gIhWErb++zGHYNZlhxrV13bjBNbFqdCtDoyJIEMXusNrJPw3bsJC7z5Si2 XanGEaZkH21eZrQQt2yrjcyr0RW0UPEvXynrq+rHbg0/hD8XG0J7VzM5lKLBGecjVrfyfglmrlEHS NCsputB+YA39gFWI1Vi0ywm96GkGx41hpBm11l25OiK+U7PMBTaWpkH8acA+6UQ0Hog0xFz2TKZ2L 87AVZGPA==; Received: from szxga07-in.huawei.com ([45.249.212.35]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgQgP-009Wfb-Vo; Tue, 11 May 2021 11:36:15 +0000 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FfbQf4SwhzCrJZ; Tue, 11 May 2021 19:33:30 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 19:36:04 +0800 From: Zhen Lei To: Jassi Brar , Matthias Brugger , linux-mediatek , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] mailbox: mediatek: Remove redundant error printing in cmdq_probe() Date: Tue, 11 May 2021 19:35:58 +0800 Message-ID: <20210511113558.5495-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_043614_210059_7B7B0D25 X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/mailbox/mtk-cmdq-mailbox.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 5665b6ea8119f1f..3900ea63b28d319 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -519,10 +519,8 @@ static int cmdq_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); cmdq->base = devm_ioremap_resource(dev, res); - if (IS_ERR(cmdq->base)) { - dev_err(dev, "failed to ioremap gce\n"); + if (IS_ERR(cmdq->base)) return PTR_ERR(cmdq->base); - } cmdq->irq = platform_get_irq(pdev, 0); if (cmdq->irq < 0)