diff mbox series

[1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe()

Message ID 20210511120426.5834-1-thunder.leizhen@huawei.com (mailing list archive)
State New
Headers show
Series [1/1] remoteproc/mediatek: Remove redundant error printing in scp_probe() | expand

Commit Message

Leizhen (ThunderTown) May 11, 2021, 12:04 p.m. UTC
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/remoteproc/mtk_scp.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Mathieu Poirier May 12, 2021, 4:42 p.m. UTC | #1
Hi Lei,

On Tue, May 11, 2021 at 08:04:26PM +0800, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
> 
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  drivers/remoteproc/mtk_scp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 9679cc26895e578..edb7f7842cb12ad 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -749,7 +749,6 @@ static int scp_probe(struct platform_device *pdev)
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram");
>  	scp->sram_base = devm_ioremap_resource(dev, res);
>  	if (IS_ERR((__force void *)scp->sram_base)) {
> -		dev_err(dev, "Failed to parse and map sram memory\n");

This kind of construct can be found several times in the remoteproc subsystem
and is also ubiquitous throughout the kernel.  Moveover removing the error
notification does not simplify the code and does little to reduce the binary
size.

As such I do not think this patch is warranted and will not move forward with
it.

Thanks,
Mathieu

>  		ret = PTR_ERR((__force void *)scp->sram_base);
>  		goto free_rproc;
>  	}
> -- 
> 2.26.0.106.g9fadedd
> 
>
diff mbox series

Patch

diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 9679cc26895e578..edb7f7842cb12ad 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -749,7 +749,6 @@  static int scp_probe(struct platform_device *pdev)
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sram");
 	scp->sram_base = devm_ioremap_resource(dev, res);
 	if (IS_ERR((__force void *)scp->sram_base)) {
-		dev_err(dev, "Failed to parse and map sram memory\n");
 		ret = PTR_ERR((__force void *)scp->sram_base);
 		goto free_rproc;
 	}