| Message ID | 20210603111455.5963-1-bernard@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mediatek: remove redundant error log print | expand |
Hi, Bernard: Bernard Zhao <bernard@vivo.com> 於 2021年6月3日 週四 下午7:15寫道： > > Fix coccicheck warning: > drivers/gpu/drm/mediatek/mtk_dsi.c:1074:2-9: line 1074 is > redundant because platform_get_irq() already prints an error. > > Signed-off-by: Bernard Zhao <bernard@vivo.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index ae403c67cbd9..e2e4fc8b1360 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1082,10 +1082,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) > > ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq, > IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi); devm_request_irq() would have below call stack to allocate memory. When allocate memory fail, it would not print any error message, doesn't it? devm_request_irq() -> devm_request_threaded_irq() -> devres_alloc() -> devres_alloc_node() -> alloc_dr() -> kmalloc_node_track_caller() Regards, Chun-Kuang. > - if (ret) { > - dev_err(&pdev->dev, "failed to request mediatek dsi irq\n"); > + if (ret) > goto err_unregister_host; > - } > > init_waitqueue_head(&dsi->irq_wait_queue); > > -- > 2.31.0 >
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index ae403c67cbd9..e2e4fc8b1360 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1082,10 +1082,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq, IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi); - if (ret) { - dev_err(&pdev->dev, "failed to request mediatek dsi irq\n"); + if (ret) goto err_unregister_host; - } init_waitqueue_head(&dsi->irq_wait_queue);
Fix coccicheck warning: drivers/gpu/drm/mediatek/mtk_dsi.c:1074:2-9: line 1074 is redundant because platform_get_irq() already prints an error. Signed-off-by: Bernard Zhao <bernard@vivo.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)