diff mbox series

irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ

Message ID 20210607035943.30292-1-mark-pk.tsai@mediatek.com (mailing list archive)
State New
Headers show
Series irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ | expand

Commit Message

Mark-PK Tsai June 7, 2021, 3:59 a.m. UTC
Only TV SoCs of Mediatek products have this controller
which inherit from MStar TV SoCs.
Don't enable it by default if ARCH_MEDIATEK is selected.
Instead, use ARCH_MSTARV7 as default value.

Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
---
 drivers/irqchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark-PK Tsai June 8, 2021, 2:49 a.m. UTC | #1
+ Daniel

> Only TV SoCs of Mediatek products have this controller
> which inherit from MStar TV SoCs.
> Don't enable it by default if ARCH_MEDIATEK is selected.
> Instead, use ARCH_MSTARV7 as default value.
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 62543a4eccc0..30f578e18a11 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
>  config MST_IRQ
>  	bool "MStar Interrupt Controller"
>  	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
> -	default ARCH_MEDIATEK
> +	default ARCH_MSTARV7
>  	select IRQ_DOMAIN
>  	select IRQ_DOMAIN_HIERARCHY
>  	help
> -- 
> 2.18.0
Matthias Brugger June 8, 2021, 2:03 p.m. UTC | #2
On 07/06/2021 05:59, Mark-PK Tsai wrote:
> Only TV SoCs of Mediatek products have this controller
> which inherit from MStar TV SoCs.
> Don't enable it by default if ARCH_MEDIATEK is selected.
> Instead, use ARCH_MSTARV7 as default value.
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 62543a4eccc0..30f578e18a11 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
>  config MST_IRQ
>  	bool "MStar Interrupt Controller"
>  	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST

We should also delete ARCH_MEDIATEK dependency.

Regards,
Matthias

> -	default ARCH_MEDIATEK
> +	default ARCH_MSTARV7
>  	select IRQ_DOMAIN
>  	select IRQ_DOMAIN_HIERARCHY
>  	help
>
Mark-PK Tsai June 8, 2021, 5:52 p.m. UTC | #3
> On 07/06/2021 05:59, Mark-PK Tsai wrote:
> > Only TV SoCs of Mediatek products have this controller
> > which inherit from MStar TV SoCs.
> > Don't enable it by default if ARCH_MEDIATEK is selected.
> > Instead, use ARCH_MSTARV7 as default value.
> > 
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > ---
> >  drivers/irqchip/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index 62543a4eccc0..30f578e18a11 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
> >  config MST_IRQ
> >  	bool "MStar Interrupt Controller"
> >  	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
> 
> We should also delete ARCH_MEDIATEK dependency.

Actually what I want to do is decouple the MST_IRQ from
ARCH_MEDIATEK, because there are only TV SoCs have this.
But if I remove the ARCH_MEDIATEK dependency, then all the
Mediatek TV SoCs kernel have to select ARCH_MSTARV7 too.
It's kind of weird.

Though it may ask some Mediatek users about MST_IRQ,
I just change the default config to prevent that all
the Mediatek kernel include this driver by default.

What would you suggest for this?

> 
> Regards,
> Matthias
> 
> > -	default ARCH_MEDIATEK
> > +	default ARCH_MSTARV7
> >  	select IRQ_DOMAIN
> >  	select IRQ_DOMAIN_HIERARCHY
> >  	help
> > 
>
diff mbox series

Patch

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 62543a4eccc0..30f578e18a11 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -576,7 +576,7 @@  config LOONGSON_PCH_MSI
 config MST_IRQ
 	bool "MStar Interrupt Controller"
 	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
-	default ARCH_MEDIATEK
+	default ARCH_MSTARV7
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
 	help