| Message ID | 20210630164623.1.I514d9aafff3a062f751b37d3fea7402f67595b86@changeid (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support to the mmsys driver to be a reset controller | expand |
Hi Enric,
I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on pza/reset/next linux/master linus/master v5.13 next-20210630]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/Add-support-to-the-mmsys-driver-to-be-a-reset-controller/20210630-224837
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: nds32-randconfig-r036-20210630 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d379d95430210479407b6123a1f2f39b5c116475
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Enric-Balletbo-i-Serra/Add-support-to-the-mmsys-driver-to-be-a-reset-controller/20210630-224837
git checkout d379d95430210479407b6123a1f2f39b5c116475
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/watchdog/mtk_wdt.c:12:10: fatal error: dt-bindings/reset-controller/mt2712-resets.h: No such file or directory
12 | #include <dt-bindings/reset-controller/mt2712-resets.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
vim +12 drivers/watchdog/mtk_wdt.c
9e5236e7cec1106 yong.liang 2020-01-15 @12 #include <dt-bindings/reset-controller/mt2712-resets.h>
c254e103082b74e yong.liang 2020-01-15 13 #include <dt-bindings/reset-controller/mt8183-resets.h>
adc318a34066817 Crystal Guo 2020-10-14 14 #include <dt-bindings/reset-controller/mt8192-resets.h>
c254e103082b74e yong.liang 2020-01-15 15 #include <linux/delay.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 16 #include <linux/err.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 17 #include <linux/init.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 18 #include <linux/io.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 19 #include <linux/kernel.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 20 #include <linux/module.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 21 #include <linux/moduleparam.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 22 #include <linux/of.h>
c254e103082b74e yong.liang 2020-01-15 23 #include <linux/of_device.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 24 #include <linux/platform_device.h>
c254e103082b74e yong.liang 2020-01-15 25 #include <linux/reset-controller.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 26 #include <linux/types.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 27 #include <linux/watchdog.h>
a44a45536f7bc2a Matthias Brugger 2015-01-13 28
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi Enric,
I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on pza/reset/next linux/master linus/master v5.13 next-20210630]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/Add-support-to-the-mmsys-driver-to-be-a-reset-controller/20210630-224837
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-a012-20210630 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 8d21d5472501460933e78aead04cf59579025ba4)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/d379d95430210479407b6123a1f2f39b5c116475
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Enric-Balletbo-i-Serra/Add-support-to-the-mmsys-driver-to-be-a-reset-controller/20210630-224837
git checkout d379d95430210479407b6123a1f2f39b5c116475
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/watchdog/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/watchdog/mtk_wdt.c:12:10: fatal error: 'dt-bindings/reset-controller/mt2712-resets.h' file not found
#include <dt-bindings/reset-controller/mt2712-resets.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
vim +12 drivers/watchdog/mtk_wdt.c
9e5236e7cec110 yong.liang 2020-01-15 @12 #include <dt-bindings/reset-controller/mt2712-resets.h>
c254e103082b74 yong.liang 2020-01-15 13 #include <dt-bindings/reset-controller/mt8183-resets.h>
adc318a3406681 Crystal Guo 2020-10-14 14 #include <dt-bindings/reset-controller/mt8192-resets.h>
c254e103082b74 yong.liang 2020-01-15 15 #include <linux/delay.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 16 #include <linux/err.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 17 #include <linux/init.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 18 #include <linux/io.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 19 #include <linux/kernel.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 20 #include <linux/module.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 21 #include <linux/moduleparam.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 22 #include <linux/of.h>
c254e103082b74 yong.liang 2020-01-15 23 #include <linux/of_device.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 24 #include <linux/platform_device.h>
c254e103082b74 yong.liang 2020-01-15 25 #include <linux/reset-controller.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 26 #include <linux/types.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 27 #include <linux/watchdog.h>
a44a45536f7bc2 Matthias Brugger 2015-01-13 28
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 27b4947b609f..085e2c96b5f4 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -11,7 +11,7 @@ #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/memory/mt8183-larb-port.h> #include <dt-bindings/power/mt8183-power.h> -#include <dt-bindings/reset-controller/mt8183-resets.h> +#include <dt-bindings/reset/mt8183-resets.h> #include <dt-bindings/phy/phy.h> #include <dt-bindings/thermal/thermal.h> #include "mt8183-pinfunc.h" diff --git a/include/dt-bindings/reset-controller/mt2712-resets.h b/include/dt-bindings/reset/mt2712-resets.h similarity index 100% rename from include/dt-bindings/reset-controller/mt2712-resets.h rename to include/dt-bindings/reset/mt2712-resets.h diff --git a/include/dt-bindings/reset-controller/mt8183-resets.h b/include/dt-bindings/reset/mt8183-resets.h similarity index 100% rename from include/dt-bindings/reset-controller/mt8183-resets.h rename to include/dt-bindings/reset/mt8183-resets.h diff --git a/include/dt-bindings/reset-controller/mt8192-resets.h b/include/dt-bindings/reset/mt8192-resets.h similarity index 100% rename from include/dt-bindings/reset-controller/mt8192-resets.h rename to include/dt-bindings/reset/mt8192-resets.h
The DT binding includes for reset controllers are located in include/dt-bindings/reset/. Move the Mediatek reset constants in there. Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- include/dt-bindings/{reset-controller => reset}/mt2712-resets.h | 0 include/dt-bindings/{reset-controller => reset}/mt8183-resets.h | 0 include/dt-bindings/{reset-controller => reset}/mt8192-resets.h | 0 4 files changed, 1 insertion(+), 1 deletion(-) rename include/dt-bindings/{reset-controller => reset}/mt2712-resets.h (100%) rename include/dt-bindings/{reset-controller => reset}/mt8183-resets.h (100%) rename include/dt-bindings/{reset-controller => reset}/mt8192-resets.h (100%)