| Message ID | 20211113052815.358793-1-liujunqi@pku.edu.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Staging: mt7621-dma: reindent to avoid '(' at the end of line | expand |
On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote: > Fixed a coding style issue. > > Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn> > --- > drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c > index 1424d01d434b..282fc807d0de 100644 > --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c > +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c > @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c) > spin_unlock_bh(&chan->vchan.lock); > } > > -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy( > - struct dma_chan *c, dma_addr_t dest, dma_addr_t src, > - size_t len, unsigned long flags) > +static struct dma_async_tx_descriptor > +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, No, this is now worse looking. The original was not pretty, but better than this. thanks, greg k-h
On Sat, 2021-11-13 at 09:02 +0100, Greg KH wrote: > On Sat, Nov 13, 2021 at 01:28:15PM +0800, Liu Junqi wrote: > > Fixed a coding style issue. This isn't really a fix, but instead is a change to make the code more like typical coding style. > > diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c [] > > @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c) > > spin_unlock_bh(&chan->vchan.lock); > > } > > > > -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy( > > - struct dma_chan *c, dma_addr_t dest, dma_addr_t src, > > - size_t len, unsigned long flags) > > +static struct dma_async_tx_descriptor > > +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, > > No, this is now worse looking. The original was not pretty, but better > than this. More typical would be to have the return value on a separate line as using * on the start of a line is poor form in the kernel. static struct dma_async_tx_descriptor * mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags) { ... }
diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c index 1424d01d434b..282fc807d0de 100644 --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c @@ -455,9 +455,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c) spin_unlock_bh(&chan->vchan.lock); } -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy( - struct dma_chan *c, dma_addr_t dest, dma_addr_t src, - size_t len, unsigned long flags) +static struct dma_async_tx_descriptor +*mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, + size_t len, unsigned long flags) { struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c); struct mtk_hsdma_desc *desc;
Fixed a coding style issue. Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn> --- drivers/staging/mt7621-dma/hsdma-mt7621.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)