| Message ID | 20220111063904.7583-5-yong.wu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MT8186 SMI SUPPORT | expand |
Il 11/01/22 07:39, Yong Wu ha scritto: > The successful return value for clk_bulk_prepare_enable is 0, rather than > "< 0". Fix this. > Hello! Thanks for this commit! However, there are a few comments... This description is a bit confusing, please reword it, something like... "Function clk_bulk_prepare_enable() returns 0 for success or a negative number for error. Fix this code style issue." In any case, you're not fixing any bad logic issue here, as the function will never return anything > 0. What you're fixing is a common pattern usage issue, so the Fixes tag can be removed since it's not really useful to schedule this commit for backport over older stable versions. After the requested changes: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > --- > drivers/memory/mtk-smi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index b883dcc0bbfa..e7b1a22b12ea 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev) > int ret; > > ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks); > - if (ret < 0) > + if (ret) > return ret; > > /* Configure the basic setting for this larb */ >
On 11/01/2022 07:39, Yong Wu wrote: > The successful return value for clk_bulk_prepare_enable is 0, rather than > "< 0". Fix this. I do not understand. The commit description does not match the code. What is the error here? > > Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops") There is no bug to fix... > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > --- > drivers/memory/mtk-smi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index b883dcc0bbfa..e7b1a22b12ea 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev) > int ret; > > ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks); > - if (ret < 0) > + if (ret) > return ret; > > /* Configure the basic setting for this larb */ > Best regards, Krzysztof
On Tue, 2022-01-11 at 10:10 +0100, AngeloGioacchino Del Regno wrote: > Il 11/01/22 07:39, Yong Wu ha scritto: > > The successful return value for clk_bulk_prepare_enable is 0, > > rather than > > "< 0". Fix this. > > > > Hello! Thanks for this commit! > However, there are a few comments... > > This description is a bit confusing, please reword it, something > like... > > "Function clk_bulk_prepare_enable() returns 0 for success or a > negative > number for error. Fix this code style issue." Thanks for your quickly reviewing. I will use this in next version and remove the "Fixes" tag. > > In any case, you're not fixing any bad logic issue here, as the > function > will never return anything > 0. > > What you're fixing is a common pattern usage issue, so the Fixes tag > can be > removed since it's not really useful to schedule this commit for > backport > over older stable versions. > > > After the requested changes: > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > > Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops") > > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > > --- > > drivers/memory/mtk-smi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > index b883dcc0bbfa..e7b1a22b12ea 100644 > > --- a/drivers/memory/mtk-smi.c > > +++ b/drivers/memory/mtk-smi.c > > @@ -480,7 +480,7 @@ static int __maybe_unused > > mtk_smi_larb_resume(struct device *dev) > > int ret; > > > > ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb- > > >smi.clks); > > - if (ret < 0) > > + if (ret) > > return ret; > > > > /* Configure the basic setting for this larb */ > > > >
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index b883dcc0bbfa..e7b1a22b12ea 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev) int ret; ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks); - if (ret < 0) + if (ret) return ret; /* Configure the basic setting for this larb */
The successful return value for clk_bulk_prepare_enable is 0, rather than "< 0". Fix this. Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops") Signed-off-by: Yong Wu <yong.wu@mediatek.com> --- drivers/memory/mtk-smi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)