| Message ID | 20220112114724.1953-3-tinghan.shen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add basic SoC support for mediatek mt8195 | expand |
[dopping Maciej, Paolo and Sean Christopherson] On 12/01/2022 12:47, Tinghan Shen wrote: > Extend driving support for I2C pins on SoC mt8195. > This property is already documented in mediatek,mt8183-pinctrl.yaml. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > Reviewed-by: Rob Herring <robh@kernel.org> Looks good to me. Linus please let me know when you are queuing this patch and I'll take the rest of the series. Another option is, that you provide an Acked-by and I can take the whole set through my branch. Regards, Matthias > --- > .../bindings/pinctrl/pinctrl-mt8195.yaml | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > index 328ea59c5466..4db4899af6b1 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > @@ -98,6 +98,32 @@ patternProperties: > drive-strength: > enum: [2, 4, 6, 8, 10, 12, 14, 16] > > + mediatek,drive-strength-adv: > + description: | > + Describe the specific driving setup property. > + For I2C pins, the existing generic driving setup can only support > + 2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they > + can support 0.125/0.25/0.5/1mA adjustment. If we enable specific > + driving setup, the existing generic setup will be disabled. > + The specific driving setup is controlled by E1E0EN. > + When E1=0/E0=0, the strength is 0.125mA. > + When E1=0/E0=1, the strength is 0.25mA. > + When E1=1/E0=0, the strength is 0.5mA. > + When E1=1/E0=1, the strength is 1mA. > + EN is used to enable or disable the specific driving setup. > + Valid arguments are described as below: > + 0: (E1, E0, EN) = (0, 0, 0) > + 1: (E1, E0, EN) = (0, 0, 1) > + 2: (E1, E0, EN) = (0, 1, 0) > + 3: (E1, E0, EN) = (0, 1, 1) > + 4: (E1, E0, EN) = (1, 0, 0) > + 5: (E1, E0, EN) = (1, 0, 1) > + 6: (E1, E0, EN) = (1, 1, 0) > + 7: (E1, E0, EN) = (1, 1, 1) > + So the valid arguments are from 0 to 7. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > + > bias-pull-down: > description: | > For pull down type is normal, it don't need add RSEL & R1R0 define > @@ -268,4 +294,13 @@ examples: > bias-pull-down; > }; > }; > + > + i2c0-pins { > + pins { > + pinmux = <PINMUX_GPIO8__FUNC_SDA0>, > + <PINMUX_GPIO9__FUNC_SCL0>; > + bias-disable; > + mediatek,drive-strength-adv = <7>; > + }; > + }; > }; >
On Thu, 2022-01-13 at 17:31 +0100, Matthias Brugger wrote: > [dopping Maciej, Paolo and Sean Christopherson] > > On 12/01/2022 12:47, Tinghan Shen wrote: > > Extend driving support for I2C pins on SoC mt8195. > > This property is already documented in mediatek,mt8183-pinctrl.yaml. > > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Looks good to me. Linus please let me know when you are queuing this patch and > I'll take the rest of the series. Another option is, that you provide an > Acked-by and I can take the whole set through my branch. > > Regards, > Matthias Hi Matthias, I want to send next version to update the CC list of this series, but I'm not sure whether this will break the conversation between you and Linus. Is it ok to send next version? or waiting the response? Best regards, TingHan > > > --- > > .../bindings/pinctrl/pinctrl-mt8195.yaml | 35 +++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > index 328ea59c5466..4db4899af6b1 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml > > @@ -98,6 +98,32 @@ patternProperties: > > drive-strength: > > enum: [2, 4, 6, 8, 10, 12, 14, 16] > > > > + mediatek,drive-strength-adv: > > + description: | > > + Describe the specific driving setup property. > > + For I2C pins, the existing generic driving setup can only support > > + 2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they > > + can support 0.125/0.25/0.5/1mA adjustment. If we enable specific > > + driving setup, the existing generic setup will be disabled. > > + The specific driving setup is controlled by E1E0EN. > > + When E1=0/E0=0, the strength is 0.125mA. > > + When E1=0/E0=1, the strength is 0.25mA. > > + When E1=1/E0=0, the strength is 0.5mA. > > + When E1=1/E0=1, the strength is 1mA. > > + EN is used to enable or disable the specific driving setup. > > + Valid arguments are described as below: > > + 0: (E1, E0, EN) = (0, 0, 0) > > + 1: (E1, E0, EN) = (0, 0, 1) > > + 2: (E1, E0, EN) = (0, 1, 0) > > + 3: (E1, E0, EN) = (0, 1, 1) > > + 4: (E1, E0, EN) = (1, 0, 0) > > + 5: (E1, E0, EN) = (1, 0, 1) > > + 6: (E1, E0, EN) = (1, 1, 0) > > + 7: (E1, E0, EN) = (1, 1, 1) > > + So the valid arguments are from 0 to 7. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > > + > > bias-pull-down: > > description: | > > For pull down type is normal, it don't need add RSEL & R1R0 define > > @@ -268,4 +294,13 @@ examples: > > bias-pull-down; > > }; > > }; > > + > > + i2c0-pins { > > + pins { > > + pinmux = <PINMUX_GPIO8__FUNC_SDA0>, > > + <PINMUX_GPIO9__FUNC_SCL0>; > > + bias-disable; > > + mediatek,drive-strength-adv = <7>; > > + }; > > + }; > > }; > >
On Tue, Jan 25, 2022 at 7:21 AM Tinghan Shen <tinghan.shen@mediatek.com> wrote: > I want to send next version to update the CC list of this series, but I'm not sure > whether this will break the conversation between you and Linus. > > Is it ok to send next version? or waiting the response? Send a new version, I'll apply the v10 version! Yours, Linus Walleij
On Sun, 2022-01-30 at 01:38 +0100, Linus Walleij wrote: > On Tue, Jan 25, 2022 at 7:21 AM Tinghan Shen <tinghan.shen@mediatek.com> wrote: > > > I want to send next version to update the CC list of this series, but I'm not sure > > whether this will break the conversation between you and Linus. > > > > Is it ok to send next version? or waiting the response? > > Send a new version, I'll apply the v10 version! > > Yours, > Linus Walleij Hi Linus, The new version is available. https://patchwork.kernel.org/project/linux-mediatek/patch/20220216113131.13145-3-tinghan.shen@mediatek.com/ v11 is rebased on 5.17-rc4 and it's the same as v10. Best regards, Tinghan
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml index 328ea59c5466..4db4899af6b1 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml @@ -98,6 +98,32 @@ patternProperties: drive-strength: enum: [2, 4, 6, 8, 10, 12, 14, 16] + mediatek,drive-strength-adv: + description: | + Describe the specific driving setup property. + For I2C pins, the existing generic driving setup can only support + 2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they + can support 0.125/0.25/0.5/1mA adjustment. If we enable specific + driving setup, the existing generic setup will be disabled. + The specific driving setup is controlled by E1E0EN. + When E1=0/E0=0, the strength is 0.125mA. + When E1=0/E0=1, the strength is 0.25mA. + When E1=1/E0=0, the strength is 0.5mA. + When E1=1/E0=1, the strength is 1mA. + EN is used to enable or disable the specific driving setup. + Valid arguments are described as below: + 0: (E1, E0, EN) = (0, 0, 0) + 1: (E1, E0, EN) = (0, 0, 1) + 2: (E1, E0, EN) = (0, 1, 0) + 3: (E1, E0, EN) = (0, 1, 1) + 4: (E1, E0, EN) = (1, 0, 0) + 5: (E1, E0, EN) = (1, 0, 1) + 6: (E1, E0, EN) = (1, 1, 0) + 7: (E1, E0, EN) = (1, 1, 1) + So the valid arguments are from 0 to 7. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3, 4, 5, 6, 7] + bias-pull-down: description: | For pull down type is normal, it don't need add RSEL & R1R0 define @@ -268,4 +294,13 @@ examples: bias-pull-down; }; }; + + i2c0-pins { + pins { + pinmux = <PINMUX_GPIO8__FUNC_SDA0>, + <PINMUX_GPIO9__FUNC_SCL0>; + bias-disable; + mediatek,drive-strength-adv = <7>; + }; + }; };